Add buzzer sounds for brew steps #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started merging the other pull request and now this pull request has conflicts. Could you please resolve the conflicts? Thanks a lot for providing this pull request. I'm looking forward to merge it. |
|
i had modify the files |
swimIan
reviewed
Jul 22, 2017
| # if you dont want a beep sound comment out like : # cbpi.BoilStepEndBeep() | ||
| cbpi.BoilStepEndBeep() | ||
| self.next() |
swimIan
reviewed
Jul 22, 2017
| # if you dont want a beep sound comment out like : # cbpi.MashStepEndBeep() | ||
| cbpi.MashStepEndBeep() | ||
| self.next() | ||
| self.next() |
swimIan
reviewed
Jul 22, 2017
modules/buzzer/__init__.py
Outdated
| @@ -11,7 +11,7 @@ class Buzzer(object): | |||
|
|
|||
| # custom beep sounds | |||
|
|
|||
| sound = ["H", 0.1, "L"] | |||
| sound = ["H", 0.1, "L", 0.1, "H", 0.1, "L", 0.1, "H", 0.1, "L"] | |||
There was a problem hiding this comment.
Your "sound" may need to match the newer one.
|
thanks for the help may be it works now |
|
One conflict missing modules/base_plugins/brew_steps/init.py The question is if I should add a central beep in the step logic instead of a beep in each step? |
|
Hi |
|
Maybe it's the right place to remind about hop dropper.
Think about passing a signal that each brewer can use it to trigger a hop
dropper.
Philip ;)
…On 30 July 2017 at 12:26, cocothenut ***@***.***> wrote:
Hi
I would add additional various buzzer-beep-sounds for various brew-steps
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHARW7My4-G4m3uG5qrN8dbxPPKnPeqPks5sTExggaJpZM4OfvPN>
.
|
|
Would love to make a hop dropper! Any leads... |
|
http://vito.tw/?p=338
This is an Arduino project.
I think it's possible to make it for raspberry.
I'm not a code guy but I can contribute the design aspects.
I think we need to think of software first and then to suggest several
options to assemble the hop dropper with the electronic parts.
…On 9 Aug 2017 8:56 a.m., "swimIan" ***@***.***> wrote:
Would love to make a hop dropper! Any leads...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHARWz6GgJ58YEcbNvBcdgCHHJSi0_fgks5sWUoogaJpZM4OfvPN>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add buzzer-beep-sounds for brew-steps
buzzer-sounds beeps at end of steps