Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Add referrerpolicy to <layer>'s content attributes #26

Merged
merged 2 commits into from
May 11, 2020

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented May 10, 2020

Closes #23.

@prushforth does this look good to you?

I noticed the way the IDL attributes are defined is different from e.g. how WHATWG HTML does it for iframe: https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:dom-iframe-referrerpolicy - the IDL attributes have links to definitions of how they reflect a particular content attribute.

I dug into this a bit and I found that the HTML Portals spec got a request to separate src IDL and content attributes.
But changing that now to include explicit definitions of each IDL attribute separate from content attributes means we should probably do that for everything, and that's perhaps something we can do later as part of (or after) the merge of this spec into MapML? This way we can just get the attribute in this spec for now...?

@prushforth
Copy link
Member

LGTM. Thanks, Robert!

But changing that now to include explicit definitions of each IDL attribute separate from content attributes means we should probably do that for everything, and that's perhaps something we can do later as part of (or after) the merge of this spec into MapML?

We'll have to get organized for the big merge for sure; let's wait until we have Simon's review in hand for that. Shouldn't be too long!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants