Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking upstream accessibility issues #247

Open
27 of 43 tasks
Malvoz opened this issue Jan 15, 2021 · 4 comments
Open
27 of 43 tasks

Tracking upstream accessibility issues #247

Malvoz opened this issue Jan 15, 2021 · 4 comments

Comments

@Malvoz
Copy link
Member

Malvoz commented Jan 15, 2021

Using code from Leaflet (and plugins) means this map component is sometimes inheriting accessibility issues.

We do have comments inline in code where fixes have been made, sometimes with links for upstream issues. Collecting them here in one spot helps get an overview of the state of accessibility in this component. This issue is to track upstream issues for discussion/fixes.

🔗 Map component

🔗 Controls in general

🔗 Zoom controls

🔗 Layer control

🔗 Fullscreen control

🔗 Markers

🔗 Popups

🔗 Context menu

🔗 Tooltips

@prushforth
Copy link
Member

Regarding:

Should be a programmatically identifiable element. Fixed in 7c86ddc. Upstream: Leaflet/Leaflet#7193.

Shouldn't this be on the mapml-viewer / map element? The leaflet-container is in shadow DOM.

@Malvoz
Copy link
Member Author

Malvoz commented Jan 15, 2021

Shouldn't this be on the mapml-viewer / map element?

The leaflet container has tabindex=0 so giving that element the accessible name means it can be announced to the user as it is focused when sequentially navigated to.

@prushforth
Copy link
Member

I'm just surprised that shadow DOM is traversable by AT, but probably because I am not too familiar with how it works and how it fails.

@Malvoz Malvoz changed the title Tracking accessibility issues upstream Tracking upstream accessibility issues Jan 27, 2021
@Malvoz
Copy link
Member Author

Malvoz commented Jan 27, 2021

@prushforth ATs construct an accessibility tree from the rendered DOM (and may be affected by CSS, e.g. display: none would hide the element and all descendants from the accessibility tree).

I've updated the list btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants