-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setters for zoom, lat, lon should change / move the map location #588
Comments
attributes are initial values only, per Maps4HTML/MapML.js#588
Our discussion this morning we proposed to (continue to) make In keeping with the In our current design and implementation, JavaScript can only change the visual state of the map by using the We are not sure how useful creating new
But we don't like this path either, because 'lat' and 'lon' are already abbreviations, so Having the ability to change the map viewer state via a setter or method with no corresponding content attribute follows the design of the Finally, in most cases changing the content attributes should not have an effect on the map, according to this comment:
Which is advice we should take into consideration when we review or create other attributes. Closing, will close the associated PRs and issues, too: Maps4HTML/web-map-doc#116 Thanks for your work, my sincere apologies for your wasted effort. I guess we learned a few things though. |
There is the zoomTo method to change all three at once, yes. But from an API perspective, if these attributes and properties aren't read-only, setting them should have a visible effect. I don't recall if there's an actual reason that they don't, but if it's a problem we should document that, or fix it.
The text was updated successfully, but these errors were encountered: