Fix link colors #554
Merged
Fix link colors #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malvoz
commented
Oct 31, 2021
Comment on lines
+60
to
+75
| /* Remove opinionated link colors set by Leaflet. */ | ||
| .leaflet-container a { | ||
| color: revert; | ||
| } | ||
| /* Don't use UA styles for links that are controls | ||
| (and don't inherit color from map into the reload button for consistency). */ | ||
| .mapml-reload-button, | ||
| .leaflet-control-container a, | ||
| .leaflet-container a.leaflet-popup-close-button, | ||
| .leaflet-container a.leaflet-popup-close-button:hover { | ||
| color: #000; | ||
| } | ||
| /* Revert above `color: #000` for legendlinks. */ | ||
| .mapml-layer-item-name a { | ||
| color: revert; | ||
| } |
There was a problem hiding this comment.
FYI: We wouldn't need most of these (and in other places where we "fix" Leaflet styles) if we could just edit the source leaflet.css file - in this case to simply remove the opinionated color they apply to links - but that's got its own set of problems I suppose...
There was a problem hiding this comment.
Managing styles would also be simpler if Leaflet just used buttons for buttons, and not links for buttons.
Related issue: #19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #553.
Preview