Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace opacity with a lighter color for the disabled state of controls #630

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Dec 7, 2021

Replaces opacity with a lighter color (same as for leaflet-disabled) on disabled controls.

Fixes #629.

Preview

  • Fixes contrast issue on disabled controls

    Before:

    low-contrast

    After:

    ok-contrast

  • Fixes outline visibility on disabled controls

    Before:

    outline-disabled-before

    After:

    outline-disabled-after

  • Fixes a stacking context issue in the layer control on drag.
    This bug doesn't seem to be present anymore, maybe something changed, or it was a browser bug.

    Before:

    stacking-context-bug

    After:

    stacking-context-bug-fixed

@Malvoz Malvoz changed the title Remove applied opacity on disabled controls Replace opacity with a lighter color for the disabled state of controls Jan 12, 2022
@prushforth prushforth force-pushed the remove-opacity-disabled-controls branch from 0b2187d to b0badd1 Compare April 20, 2023 14:33
Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@prushforth prushforth merged commit 1988836 into Maps4HTML:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opacity issues on disabled controls
2 participants