Change packaging to create only dist/mapml-viewer.js and dist/web-map.js (everything bundled) #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prushforth
commented
Sep 18, 2024
prushforth
commented
- Change rollup to produce two targets: mapml-viewer.js and web-map.js
- Refactor index.js, create index-web-map.js as separate start point for web-map.js build / rollup target
- All .js files are bundled into the main targets. To Do: tree-shaking?
- Move import statements into .js files that depend on the import.
- Remove most symbols from the M global variable, leaving TCRS mostly
- Create and import GlobalM.js. Rename options.js->DefaultMapOptions.js
- pmtilesRules.js now does not require M.protomapsL usage, just use protomapsL import symbols directly (will affect experiment).
- Update tests to keep them running / not flaky if possible
- Refactor index.js, create index-web-map.js as separate start point for web-map.js build / rollup target - All .js files are bundled into the main targets. To Do: tree-shaking? - Move import statements into .js files that depend on the import. - Remove most symbols from the M global variable, leaving TCRS mostly - Create and import GlobalM.js. Rename options.js->DefaultMapOptions.js - pmtilesRules.js now does not require M.protomapsL usage, just use protomapsL import symbols directly (will affect experiment). - Update tests to keep them running / not flaky if possible
prushforth
pushed a commit
to prushforth/experiments
that referenced
this pull request
Sep 18, 2024
prushforth
pushed a commit
to Maps4HTML/experiments
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.