forked from cds-snc/gcds-components
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcds-map component based on mapml-viewer #1
Draft
prushforth
wants to merge
12
commits into
Maps4HTML:main
Choose a base branch
from
prushforth:mapml-viewer-gcds-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
October 7, 2024 21:41
3fef7a9
to
20abf3f
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ds-snc#660) * refactor(gcds-signature): Signature alternative text to be bilingual * Optimize rendering
…snc#662) * chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
* build: remove console errors from tests * build: remove react-ssr CSS and gitignore
…s list (cds-snc#666) fix: error summary focusing gcds element from error-links list
Dynamically render layers based on passed props Add gcds-map-layer, update gcds-map to use it. Update index.html with example map. Need to figure out how to get a storybook together. Update gcds-map.stories.tsx Add dependency on @maps4html/mapml Updates for gcds-map Remove dep on npm @maps4html/mapml
Sync package.json with upstream
Use suggested integrity SHA for mapml.js temporarily until it can be included in dist Co-authored-by: Pierre Dubois <[email protected]>
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
October 10, 2024 14:29
802dd3a
to
b4af354
Compare
gcds-map attributes effects. To do: add examples for gcds-map-layer properties, probably by renaming properties.mdx and using that as the menu item for "Map Layer"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - contribute to this PR using the gh API