Fix breaking argv change in Chromium 89.0.4389.86 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`process` does not have guaranteed value in Chromium 89.0.4389.86, causing site-breaking changes to projects that take dependency on colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We take a dependency on Winston, which takes a dependency on colors.js. This morning our dev team upgraded to Chromium 89.0.4389.86, which does not guarantee that
processhas an argv field, causing site-breaking changes to projects that take dependency on colors.This updates so if there is no argv, it resorts to an empty array (alternate behavior may be desired).