Revert infinite loop bug #286
Open
+2
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricPKerr
force-pushed
the
revert-infinite-loop
branch
from
46209a8
to
1b47a63
Compare
EricPKerr
force-pushed
the
revert-infinite-loop
branch
from
1b47a63
to
02e6e4a
Compare
dfederm
approved these changes
Jan 9, 2022
mikolajkalwa
approved these changes
Jan 9, 2022
wiktorkowalski
approved these changes
Jan 9, 2022
nooreldeensalah
approved these changes
Jan 9, 2022
meiram-tr
reviewed
Jan 9, 2022
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "colors", | |||
| "description": "get colors in your node.js console", | |||
| "version": "1.4.44-liberty-2", | |||
| "version": "1.5.0", | |||
There was a problem hiding this comment.
better use 1.4.5 in order to updated all
There was a problem hiding this comment.
The problematic previous version is 1.4.44 (-liberty-2). So it would have to be 1.4.45 if you think it needs to be a minor version. Was just attempting to make it simple for people to avoid all of the 1.4.X code given the severity of this.
Solixity
suggested changes
Jan 9, 2022
brahian-pena
approved these changes
Jan 9, 2022
|
LGTM ✔️ |
deyvisonrocha
approved these changes
Jan 10, 2022
|
I'm unable to merge or npm publish this. Is a maintainer able to do that? |
|
It won't be merged. The author did this on purpose, it's not a mistake nor a bug. They did similar things on their other packages, such as Faker.js (they removed the source, and push v6.6.6 to NPM that breaks everything). |
Kowalski-Mateusz
approved these changes
Jan 10, 2022
|
Don't merge this, it breaks functionality of the new library and how I use it. |
hello-smile6
approved these changes
Jan 14, 2022
TechStudent10
approved these changes
Jan 17, 2022
hello-smile6
approved these changes
Jan 17, 2022
stifskere
approved these changes
Aug 24, 2022
PululuK
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a critical error described here: 074a0f8