Various updates, fixes and enhancements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of just IObservables (to facilitate testing in consuming code by sending fake messages) * Add missing functionality for authenticated (private) streams * Add missing functionality for ReconnectionRequest * Fix boken functionality for ErrorResponse * Introduce new IBitstampWebsocketClient interface * Remove superfluous IBitstampCommunicator interface and implementation class * Refactor to use file-scoped namespaces * Remove custom validation utility (so that exception stack traces are raised from the method itself rather than the ulitity method) * Replace LibLog package reference with Microsoft.Extensions.Logging.Abstractions (as LigLog is marked as deprecated) * Update other NuGet packages to the latest versions
shaynevanasperen
changed the title
| <PackageId>Bitstamp.Client.Websocket</PackageId> | ||
| <Version>1.0.0</Version> | ||
| <Version>2.0.0-beta.7</Version> |
There was a problem hiding this comment.
You'll want to update this to remove the prerelease suffix.
… remove it from the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've exposed the underlying
Subject<T>members in theBitstampClientStreamsclass. This is because I want to be able to stream fake messages for testing my program which uses this library. Although that was already possible by using fakeIWebsocketClientobjects, that method is very clunky and requires that I send raw text instead of just POCO objects. There is no good reason for hiding theSubject<T>members behindIObservable<T>, so the most straight-forward way to enable easy testing is to just expose theSubject<T>members directly.Summary of changes:
IBitstampWebsocketClientinterfaceIBitstampCommunicatorinterface and implementation classLibLogpackage reference withMicrosoft.Extensions.Logging.Abstractions(as LigLog is marked as deprecated)