Fix scaling issues #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've noticed this issue also. I hope this PR gets merged! |
Current coverage is 57.82% (diff: 50.00%)@@ master #38 diff @@
==========================================
Files 42 42
Lines 1252 1252
Methods 103 103
Messages 0 0
Branches 195 195
==========================================
Hits 724 724
Misses 528 528
Partials 0 0
|
|
Does look good, thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-lifx has always had issues with scaling. Quite often the scaling with
node-lifxdoesn't match what the LIFX app is showing.Math.roundshould be used instead ofMath.floor.For test purposes, set
Brightnessto49%and then read back the corresponding value and it will read48%.This PR resolves that discrepancy.