Remove markdown - htmlparser2 patch #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the processing order adjusted to follow nunjucks -> markdown -> html, a markdown - htmlparser patch for code blocks and inline code is no longer necessary. Let's remove the patch as such. This also allows incorporating markdown plugins with conflicting html syntax with ease, no longer needing additional html patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Follow up to #1403, #1433, #1434
Original feature: MarkBind/htmlparser2#1
Remove the markdown - htmlparser2 patch which is no longer necessary by adhering to nunjucks -> markdown -> html
Overview of changes:
Simple removal of the patch, no functional test diffs observed, also no unexpected ones in the docs
Anything you'd like to highlight / discuss:
na
Testing instructions:
na
Proposed commit message: (wrap lines at 72 characters)
Remove markdown - htmlparser2 patch
With the processing order adjusted to follow nunjucks -> markdown ->
html, a markdown - htmlparser patch for code blocks and inline code is
no longer necessary.
Let's remove the patch as such.
This also allows incorporating markdown plugins with conflicting html
syntax with ease, no longer needing additional html patches.
Checklist: ☑️