Patch htmlparser2 instead of rely on MarkBind fork #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [ ] Documentation update
• [ ] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [x] Other, please explain:
Patch htmlparser2
Resolves #396
Resolves #582
Closes #606
Unblocks #819
What is the rationale for this request?
Not being able to use the latest version of npm seems rather backward for users and devs.
What changes did you make? (Give an overview)
^1.6.12
to~1.7.5
to have no output diff — fixes test broken by 1Provide some example code that this change will affect:
-
Is there anything you'd like reviewers to focus on?
Is this the lesser evil? At least, this should have reliable behaviour for end-users regardless of their npm version.
Testing instructions:
npm i
using npm 6.12.1 (packaged with Node.js LTS version 12.13.1) or higher doesn't modify package-lock.json.npm ci
)._site/
in .gitignore:Site.prototype._setTimestampVariable
in MarkBind source code for cleaner diff later.markbind build
.npm ci
) this PR.Site.prototype._setTimestampVariable
again if you need to.markbind build
.