Allow key-value options to be passed in for harmonization flows in UI #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds select-key-values component for displaying input boxes for entry Includes controls for adding and removing inputs Persists options (and other settings) in local storage
Option removal is now persisted. Adds event emitter for remove event (also for add event).
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
ayuwono
reviewed
Jan 29, 2018
|
Jenkins Build successful |
|
@aebadirad, OK, looks like this got inadvertently closed when I was doing housekeeping during the rebase of my branch (in the process, I deleted the wooldridge:DHFPROD-167 branch), my bad. I can refile a PR with the updated, rebased branch. |
|
Opened this feature PR again as: #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The features allows the user to add a configurable number of key-value options.
The key-value list is built as a configurable Angular component.
Harmonization flow options in the UI are persisted in local storage.
Also fixes marklogic/datahub-central#1078 .