[BUG] #15113 breaks CR10_STOCKDISPLAY support on SKR Mini E3 #15141

vincentbaeten · 2019-09-02T18:35:41Z

Description

Today I wanted to flash the latest firmware of bugfix-2.0.x on my skr mini e3 but after flashing, only the backlight will turn on and no status screen will show up. After a bit of testing, I've found that the culprit is #15113.

Steps to Reproduce

Flash #15113

Expected behavior: [What you expect to happen]

Normal status screen

Actual behavior: [What actually happens]

No status screen.

Additional Information

Include a ZIP file containing your Configuration.h and Configuration_adv.h files.
config.zip
Provide pictures or links to videos that clearly demonstrate the issue.
See How Can I Contribute for additional guidelines.

The text was updated successfully, but these errors were encountered:

reloxx13 · 2019-09-02T19:15:37Z

had the same today,

had to remove eeprom emulation Use Flash-based EEPROM on SKR mini-E3 #15126
and the commit for [BUG] [bugfix-2.0.x] Unstable MKS MINI 12864 on fast MCU #13550 (this one is before ur 15113, r u sure its that?)

both broke my skr mini e3

edit:
to 1., note u dont have eeprom settings enabled in ur config
to 2., tested again, it does not work with commit 23bb40d #13550

thisiskeithb · 2019-09-02T19:33:43Z

I just flashed my Ender-3 with CR10_STOCKDISPLAY and don't have this issue.

Have you tried cleaning your libraries (click the trash can icon in your IDE or manually delete the .pio folder)?

reloxx13 · 2019-09-02T19:38:47Z

I just flashed my Ender-3 with CR10_STOCKDISPLAY and don't have this issue.

Have you tried cleaning your libraries (click the trash can icon in your IDE or manually delete the .pio folder)?

Do u have the SKR MINI E3 Board ???

PS: yes, i cleaned everything, in my user dir and in my marlin dir.

thisiskeithb · 2019-09-02T19:44:47Z

Do u have the SKR MINI E3 Board ???

No. I am using an SKR 1.3. I was going off the title assuming OP meant that CR10_STOCKDISPLAY was broken.

It looks like this just affects the SKR Mini E3 so far.

vincentbaeten · 2019-09-02T20:06:50Z

Do u have the SKR MINI E3 Board ???

No. I am using an SKR 1.3. I was going off the title assuming OP meant that CR10_STOCKDISPLAY was broken.

It looks like this just affects the SKR Mini E3 so far.

Sorry it is a bit misleading indeed. I've changed the title to be more specific.

had the same today,

had to remove eeprom emulation Use Flash-based EEPROM on SKR mini-E3 #15126

and the commit for [BUG] [bugfix-2.0.x] Unstable MKS MINI 12864 on fast MCU #13550 (this one is before ur 15113, r u sure its that?)

both broke my skr mini e3

edit:
to 1., note u dont have eeprom settings enabled in ur config
to 2., tested again, it does not work with commit 23bb40d #13550

It is working for me on commit 23bb40d

thisiskeithb · 2019-09-02T22:05:12Z

I just tried CR10_STOCKDISPLAY and REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER on my SKR Mini 1.1 (non E3 or DIP version) and neither work with 12c595c.

Unsurprisingly, REPRAP_DISCOUNT_SMART_CONTROLLER works.

shitcreek · 2019-09-03T18:07:09Z

Got the same issue with REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and BOARD_BIGTREE_SKR_V1_3, but it works with CR10_STOCKDISPLAY

zombu2 · 2019-09-04T05:21:38Z

Seems it's related to boards with STM mcu only ran into same issue then tried various other mcu's none showed the issue of no display

thisiskeithb · 2019-09-04T06:45:32Z

Seems it's related to boards with STM mcu only

BOARD_BIGTREE_SKR_V1_3 is LPC1768. So maybe it's 32-bit? I only have LPC1768 and STM32F1 to test with.

I've been playing around with a MKS GEN-L and various 12864-type LCDs the past few nights and Mega2560 is unaffected.

ManuelMcLure · 2019-09-04T06:52:47Z

My Re-ARM works fine with the RRD Full Graphics Smart Controller and the latest bugfix-2.0.x sources, so it’s not a basic 32 bit problem.

zombu2 · 2019-09-04T23:46:45Z

swap out these files in /Marlin/src/lcd/dogm/ from an older tree
ultralcd_st7920_u8glib_rrd_AVR.cpp
ultralcd_st7920_u8glib_rrd_AVR.h
u8g_dev_st7920_128x64_HAL.cpp

that will get the display working again

thisiskeithb · 2019-09-04T23:51:17Z

swap out these files in /Marlin/src/lcd/dogm/ from an older tree
ultralcd_st7920_u8glib_rrd_AVR.cpp
ultralcd_st7920_u8glib_rrd_AVR.h
u8g_dev_st7920_128x64_HAL.cpp

that will get the display working again

Yes, that was part of 12c595c, but I don't understand the changes, so I don't know how to fix it 😄

zombu2 · 2019-09-04T23:56:36Z

well a workaround is to drop older files in before the change which will make the display work
looks like the display is not initialized and that happens only one some boards STM like mine for example

tpruvot · 2019-09-05T00:01:12Z

its from PR #15113 we badly supposed the AVR.cpp file was specific to AVR platform, but both compile on STM32 (F4 at least, maybe F1 too for this RRD)

zombu2 · 2019-09-05T00:06:20Z

skr mini too not sure what mcu that uses

tpruvot · 2019-09-05T00:15:04Z

mini is STM32F103R (64pins)

AbelCS · 2019-09-05T12:15:59Z

Same problem here with E3 DIP, researching a bit I've reached 12c595c and reviewed the code, but too much u8g for me...

Maybe @GMagician can help

GMagician · 2019-09-05T12:30:48Z

The only changes done that may affect other boards than samd51 are the ones in:
Marlin/src/lcd/dogm/u8g_dev_st7920_128x64_HAL.cpp,
arlin/src/lcd/dogm/ultralcd_st7920_u8glib_rrd_AVR.h and Marlin/src/lcd/dogm/ultralcd_st7920_u8glib_rrd_AVR.cpp that changed lines 26-27, 30 and 154-157
I can't see nothing else in 12c595c.
Reverting as stated by @zombu2 should fix. The reported fix in that PR where a deviation from my original post that involved only samd51.

tpruvot · 2019-09-05T17:36:56Z

just need to change the top ifdef in the 2 cpp files

cf. issues MarlinFirmware#15141 and MarlinFirmware#15155

tpruvot · 2019-09-08T01:08:38Z

Thanks to confirm if its resolved...

reloxx13 · 2019-09-08T08:09:22Z

updated yesterday and it works if TMC_DEBUG is disabled.

Wont boot with TMC_DEBUG enabled.

AbelCS · 2019-09-09T17:25:04Z

updated yesterday and it works if TMC_DEBUG is disabled.

Wont boot with TMC_DEBUG enabled.

What board are you using?

Works well for me with TMC_DEBUG enabled on SKR E3 DIP.

reloxx13 · 2019-09-09T17:36:09Z

skr mini e3

zombu2 · 2019-09-09T20:55:07Z

did not try it on a mini but no issues on skr 1.3 or skr pro
not sure how tmc debug could be related to display o.0

reloxx13 · 2019-09-09T22:20:44Z

note: TMC_DEBUG worked before adding the EEPROM emulation

thisiskeithb · 2019-09-09T22:21:03Z

Thanks to confirm if its resolved...

I'm still getting a blank screen with CR10_STOCKDISPLAY on an SKR Mini 1.1 using the latest commit (841c8ce). Link to the test branch I'm using.

REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER (native & emulated) work.

No issues with any of those LCDs on an SKR 1.3.

Edit: ~~There's no CR10_STOCKDISPLAY pins support for the SKR Mini 1.1. Dope~~.

66338ed brings CR10_STOCKDISPLAY Support to the SKR Mini 1.1 and it works great.

AmiSMB · 2019-09-11T15:13:48Z

I have had a similar issue to this but did some digging and found that my board was not booting due to having TMC_DEBUG enabled. It was this thread and the statement by reloxx13 that I thought I would try remarking it out to see if it fixed the problem. I think that there maybe a clash with EEPROM emulation as well as #15180 which allows the SD card to be seen via USB. I have opened up issue #15226 with my findings.

AbelCS · 2019-09-11T20:26:43Z

I'm a bit lost with this issue, on SKR E3 DIP the other day all was working great with #15172 (TMC_DEBUG, EEPROM EMULATION, and all the stuff), today I pulled all new changes to my repo and with same configuration I've got blank screen, so I decided to revert to #15172 with the same config, and now I'm getting blank screen all time.

Disabling TMC_DEBUG makes it work 😑

sjasonsmith · 2019-09-22T01:38:54Z

I just rebased onto commit 7fc4f7b815949eb9ec4b8e7c5399d154d0f28c94 (from yesterday), and it seems to be working fine.

I'm on an SKR-mini-E3. Display comes up, and I'm able to query TMC_DEBUG info as well.

thisiskeithb · 2019-09-22T02:00:10Z

I'm on an SKR-mini-E3. Display comes up, and I'm able to query TMC_DEBUG info as well.

With emulated EEPROM enabled?

matheusmbar · 2019-09-22T02:19:35Z

I've just setup Marlin firmware in my Ender 3 with SKR E3 DIP and the CR10 Stock display is working too.

I'm at commit 7fc4f7b from today (september 21st)

I have TMC_DEBUG, EEPROM_SETTINGS and EEPROM_AUTO_INIT enabled.

sjasonsmith · 2019-09-22T02:41:00Z

With emulated EEPROM enabled?

I have EEPROM_SETTINGS enabled, and the pins file defines FLASH_EEPROM_EMULATION. I confirmed I can save settings and they persist across reboots without an SD card installed.

boelle · 2019-10-12T09:53:31Z

@vincentbaeten does it work for you with latest 2.0.x ?

boelle · 2019-10-24T21:37:12Z

Lack of Activity
This issue is being closed due to lack of activity. If you have solved the
issue, please let us know how you solved it. If you haven't, please tell us
what else you've tried in the meantime, and possibly this issue will be
reopened.

github-actions · 2020-07-04T05:03:52Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

vincentbaeten changed the title ~~[BUG] #15113 breaks CR10_STOCKDISPLAY support~~ [BUG] #15113 breaks CR10_STOCKDISPLAY support on SKR Mini E3 Sep 2, 2019

thisiskeithb referenced this issue Sep 2, 2019

Flash-based EEPROM on SKR Mini E3 DIP (#15128)

59152f2

This was referenced Sep 4, 2019

[BUG] no display skr pro and reprapdiscount glcd #15155

Closed

Increase Default MKS MINI 12864 Init Contrast #15139

Merged

tpruvot added a commit to tpruvot/Marlin that referenced this issue Sep 5, 2019

Fix for RRD/CR10 LCD on STM32F1 & F4

61108f6

cf. issues MarlinFirmware#15141 and MarlinFirmware#15155

tpruvot mentioned this issue Sep 5, 2019

Fix RRD/CR10 LCD on STM32F1/F4 #15172

Merged

boelle closed this as completed Oct 24, 2019

Grrby mentioned this issue Nov 10, 2019

[BUG] Blank LCD on Ender 2 with SKR 1.3 board, with stock LCD #15624

Closed

github-actions bot locked and limited conversation to collaborators Jul 4, 2020

[BUG] #15113 breaks CR10_STOCKDISPLAY support on SKR Mini E3 #15141

[BUG] #15113 breaks CR10_STOCKDISPLAY support on SKR Mini E3 #15141

Comments

vincentbaeten commented Sep 2, 2019

Description

Steps to Reproduce

Additional Information

reloxx13 commented Sep 2, 2019 • edited Loading

thisiskeithb commented Sep 2, 2019

reloxx13 commented Sep 2, 2019 • edited Loading

thisiskeithb commented Sep 2, 2019

vincentbaeten commented Sep 2, 2019 • edited Loading

thisiskeithb commented Sep 2, 2019 • edited Loading

shitcreek commented Sep 3, 2019 • edited by thinkyhead Loading

zombu2 commented Sep 4, 2019

thisiskeithb commented Sep 4, 2019

ManuelMcLure commented Sep 4, 2019

zombu2 commented Sep 4, 2019

thisiskeithb commented Sep 4, 2019

zombu2 commented Sep 4, 2019 • edited Loading

tpruvot commented Sep 5, 2019

zombu2 commented Sep 5, 2019

tpruvot commented Sep 5, 2019

AbelCS commented Sep 5, 2019

GMagician commented Sep 5, 2019 • edited Loading

tpruvot commented Sep 5, 2019

tpruvot commented Sep 8, 2019

reloxx13 commented Sep 8, 2019 • edited Loading

AbelCS commented Sep 9, 2019

reloxx13 commented Sep 9, 2019

zombu2 commented Sep 9, 2019

reloxx13 commented Sep 9, 2019

thisiskeithb commented Sep 9, 2019 • edited Loading

AmiSMB commented Sep 11, 2019

AbelCS commented Sep 11, 2019 • edited Loading

sjasonsmith commented Sep 22, 2019

thisiskeithb commented Sep 22, 2019

matheusmbar commented Sep 22, 2019 • edited Loading

sjasonsmith commented Sep 22, 2019

boelle commented Oct 12, 2019

boelle commented Oct 24, 2019

github-actions bot commented Jul 4, 2020

reloxx13 commented Sep 2, 2019 •

edited

Loading

reloxx13 commented Sep 2, 2019 •

edited

Loading

vincentbaeten commented Sep 2, 2019 •

edited

Loading

thisiskeithb commented Sep 2, 2019 •

edited

Loading

shitcreek commented Sep 3, 2019 •

edited by thinkyhead

Loading

zombu2 commented Sep 4, 2019 •

edited

Loading

GMagician commented Sep 5, 2019 •

edited

Loading

reloxx13 commented Sep 8, 2019 •

edited

Loading

thisiskeithb commented Sep 9, 2019 •

edited

Loading

AbelCS commented Sep 11, 2019 •

edited

Loading

matheusmbar commented Sep 22, 2019 •

edited

Loading