[BUG] Compilation fails with DAC steppers and screen enabled

[0r31]

Hi all,

Please find below a bug i suspect in Marlin 2.0 current revision.

Regards,
Orel

Description

As stated in the issue title, the compilation fails when DAC steppers and screen features are enabled.

Steps to Reproduce

Configuration files: Marlin_config.zip

From the current revision of bugfix-2.0.x branch, just change the MOTHERBOARD to BOARD_RIGIDBOARD_V2 for instance (a board for which DAC steppers are enabled) and uncomment REPRAP_DISCOUNT_SMART_CONTROLLER in Configuration.h. Then compile using the default platformio environment.

Expected behavior: Compilation success.

Actual behavior: Compilation failure. See below for compilation log.

Additional Information

Compilation log: https://pastebin.com/eXsx7AWy

[0r31]

Hi again,

First of all, thanks to @boelle to add the compilation log to pastebin. I was aware that putting a log "as it is" could be annoying but i have no clue on what to do with logs in the bug template.

Regarding the potential bug, i guess the issue is around the GET_TEXT macro or the way the EDIT_ITEM macro handles labels or the way this label is built...

I am fine to submit a pull request, but i want to be aligned with the coding rules...
It is easy to get rid of that bug in changing the LABEL argument of this EDIT_ITEM call to a "valid" one, but it is not the right way to fix it.

Regards,
Orel

[boelle]

@dagorel did you make a PR to fix this?

[0r31]

Hi @boelle ,

Actually it can be solved in defining new labels for each axis (MSG_DAC_PERCENT_X, MSG_DAC_PERCENT_Y, MSG_DAC_PERCENT_Z) and use MSG_DAC_PERCENT_##A in the EDIT_DAC_PERCENT macro. But i am not happy with this solution so i try to find another one before proposing a PR.

Regards,
Orel

[boelle]

@dagorel since 2.0 was just released a few days ago has this changed this issue at all?

[0r31]

Hi @boelle ,

It is the very same with the new 2.0 branch so i submit a pull request on the bugfix-2.0.x branch.

Regards,
Orel

[boelle]

:-) great, nice when people contribute

[boelle]

let hope @thinkyhead hits merge soon

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.