Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERLIN 2.0.x missing menu items #17784

Closed
geekgamer2001 opened this issue Apr 28, 2020 · 30 comments
Closed

MERLIN 2.0.x missing menu items #17784

geekgamer2001 opened this issue Apr 28, 2020 · 30 comments

Comments

@geekgamer2001
Copy link

i just updated and i can't find auto home or half the features i saw on 1.1.9 including auto home

@geekgamer2001 geekgamer2001 changed the title MERLIN 2.0.xx no autohome? MERLIN 2.0.x no autohome? Apr 28, 2020
@geekgamer2001
Copy link
Author

i see it in the code // Auto Home // GCODES_ITEM(MSG_AUTO_HOME, G28_STR); #if ENABLED(INDIVIDUAL_AXIS_HOMING_MENU) GCODES_ITEM(MSG_AUTO_HOME_X, PSTR("G28X")); GCODES_ITEM(MSG_AUTO_HOME_Y, PSTR("G28Y")); GCODES_ITEM(MSG_AUTO_HOME_Z, PSTR("G28Z")); #endif

@ellensp
Copy link
Contributor

ellensp commented Apr 28, 2020

so enable INDIVIDUAL_AXIS_HOMING_MENU in Configuration.h

@geekgamer2001
Copy link
Author

but I just want to home all

@ellensp
Copy link
Contributor

ellensp commented Apr 29, 2020

add the following line, after GCODES_ITEM(MSG_AUTO_HOME_Z, PSTR("G28Z"));
GCODES_ITEM(MSG_AUTO_HOME_ALL, PSTR("G28"));

@geekgamer2001
Copy link
Author

and cooldown just saw that was missing

@zroadhouse
Copy link

zroadhouse commented Apr 29, 2020

I'm seeing similar disappearing "Auto Home" menu item after rebasing my config onto the most recent bugfix-2.0.x. Maybe Streamline menu item logic (#17664) changed something? I'm compiling now on the commit prior to that one to see.

@ellensp
Copy link
Contributor

ellensp commented Apr 29, 2020

Cooldown only appears when hot end is hot

@geekgamer2001
Copy link
Author

it was if i recall correctly

@geekgamer2001
Copy link
Author

yeah i went to select cooldown to move my printer was heated

@zroadhouse
Copy link

Preheat PLA had also disappeared from the Temperature menu. Reverting bugfix-2.0.x to f709c56 worked for me. Strongly suspect something in the #17664 change.

@geekgamer2001
Copy link
Author

geekgamer2001 commented Apr 29, 2020

ya just saw that how odd it's like many options are gone I will try to revert to that soon

@ellensp
Copy link
Contributor

ellensp commented Apr 29, 2020

What lcd's are you guys using? (shouldn't make any difference, but...)

@Evg33
Copy link
Contributor

Evg33 commented Apr 29, 2020

And "Temp/Preheat PLA"
some menu items lost in space ? :)
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

@geekgamer2001
Copy link
Author

that produces an error

@thisiskeithb
Copy link
Member

thisiskeithb commented Apr 29, 2020

Preheat PLA had also disappeared from the Temperature menu. Reverting bugfix-2.0.x to f709c56 worked for me. Strongly suspect something in the #17664 change.

I can confirm that several items are missing from the menus after 4f003fc / #17664

@xoniq
Copy link

xoniq commented Apr 29, 2020

And "Temp/Preheat PLA"
some menu items lost in space ? :)
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

Same LCD, can confirm, just updated my printer to latest git version, I miss several items, but the first item I noticed, I wanted to home all, but its missing. And after above reply, I also miss the preheat PLA option.

@zroadhouse
Copy link

You can find my configuration here if its helpful => zroadhouse#1

@geekgamer2001
Copy link
Author

well shall i close this since we know the root cause or wait till its fixed

@geekgamer2001
Copy link
Author

geekgamer2001 commented Apr 29, 2020

in the meantime, I'm going to revert to [4f003fc]
and write down all the menu options then go back to current and write down menu options for that and comment the missing menu items in #17664

@firepower9966
Copy link

firepower9966 commented Apr 29, 2020

Also missing Autohome in LCD menu, individual homing is enabled. using 2004 Smart LCD

@xoniq
Copy link

xoniq commented Apr 29, 2020

Another thing I cannot find back: cool down. I had the printer hot to change filament, but I could not cool it down without going to temperature and set it to 0.

@geekgamer2001
Copy link
Author

yeah and cooldown is a important feature

@geekgamer2001
Copy link
Author

revert to 4f003fc for now as that has all options

@geekgamer2001 geekgamer2001 changed the title MERLIN 2.0.x no autohome? MERLIN 2.0.x missing menu items Apr 29, 2020
@thisiskeithb
Copy link
Member

well shall i close this since we know the root cause or wait till its fixed

Please leave this issue open so it can be tracked.

@thisiskeithb
Copy link
Member

The breaking changes were reverted in e8b0796, so this issue can be closed.

@Evg33
Copy link
Contributor

Evg33 commented Apr 29, 2020

all ok

@thisiskeithb
Copy link
Member

Yes, I tested the changes as well and can confirm it's been fixed 🙂

@chepo92
Copy link
Contributor

chepo92 commented Apr 30, 2020

Lol I just synced yesterday and facing this issue, syncing again

@Evg33
Copy link
Contributor

Evg33 commented Apr 30, 2020

@chepo92 fixed in "Revert menu_item_if ahead of refactor" e8b0796

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants