Streamline menu item logic

[thinkyhead]

Background: Menu items are processed in a loop from the top of the screen to the bottom, so any visible menu items will be processed up to 5 times per menu screen. This wastes processing and may cause unwanted side-effects since any un-protected function calls inside of menus will also be repeated.

Solutions:

• Add the MENU_ITEM_IF() macro to replace if clauses inside of menu screens. The clause essentially gets moved "inside" the menu item, so it will only be run when the current menu item is being evaluated instead of 4 or 5 times per screen handler call.
• Get conditions for item display at the top of menus, outside of the loop, so they can be applied to more than one item with only the single call.

The compiler will optimize out the inner check for "is this the current menu item?" (implicit in MENU_ITEM(...) when the outer check is used, so there is no extra cost to using MENU_ITEM_IF.

[Evg33]

SKR1.4T
pio upgrade
pio run -t clean
pio update
pio run

Compiling .pio\build\LPC1769\src\src\lcd\menu\menu_main.cpp.o
In file included from Marlin\src\lcd\menu\menu_info.cpp:31:
Marlin\src\lcd\menu\menu_info.cpp: In function 'void menu_info_printer()':
Marlin\src\lcd\menu\menu.h:443:50: error: expected unqualified-id before ')' token
  443 |     MenuItem_static::draw(_lcdLineNr, PLABEL, ##V);     \
      |                                                  ^
Marlin\src\lcd\menu\menu.h:448:5: note: in expansion of macro 'STATIC_ITEM_INNER_P'
  448 |     STATIC_ITEM_INNER_P(PLABEL, ##V);   \
      |     ^~~~~~~~~~~~~~~~~~~
Marlin\src\lcd\menu\menu.h:460:39: note: in expansion of macro 'STATIC_ITEM_P'
  460 | #define STATIC_ITEM(LABEL,      V...) STATIC_ITEM_P(  GET_TEXT(LABEL), ##V)
      |                                       ^~~~~~~~~~~~~
Marlin\src\lcd\menu\menu_info.cpp:246:5: note: in expansion of macro 'STATIC_ITEM'
  246 |     STATIC_ITEM(
      |     ^~~~~~~~~~~
*** [.pio\build\LPC1769\src\src\lcd\menu\menu_info.cpp.o] Error 1
============================================ [FAILED]

[thinkyhead]

Thanks! That error got patched along the way.

[thisiskeithb]

@thinkyhead: Several items are missing from the menus after this (Home All/ PLA preheat, Cooldown, just to make a few). I haven’t compared every menu, but something broke with this PR.

[thinkyhead]

Yes, I expected some things to fail. Please diagnose if you find the time. I have only time to patch issues and no time to test them.

[geekgamer2001]

here is a full list of menu options that i found to be missing in the current version after reverting to 4f003fc now my printer does not have some other things so these are just the options available to me

Auto Home
Preheat PLA
Cooldown
about printer

[thinkyhead]

I've got a better refactor coming pretty soon, so the MENU_ITEM_IF stuff is reverted for now.