Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Thermal runaway detected while using #999 & #998 virtual temp sensors #18525

Closed
Patag opened this issue Jul 3, 2020 · 13 comments
Closed

Comments

@Patag
Copy link

Patag commented Jul 3, 2020

Bug Description

Thermal runaway is detected at startup and stops Marlin.

My Configurations

BTT SKR Pro v1.1 on test bench
Conf.zip

Steps to Reproduce

  1. Download Marlin bugfix 2.x after 30/06 (don't know exactly what commit)
  2. define TEMP_SENSOR_0 999 and TEMP_SENSOR_BED 998
  3. Compile and install
  4. Restart

Expected behavior: Normal Marlin startup

Actual behavior: Thermal runaway detection "MAX TEMP on E1" or something like that.

Additional Information

This happend after 30/06 commit

@ellensp
Copy link
Contributor

ellensp commented Jul 3, 2020

If you give any heating gcodes you can still trigger a Thermal runaway.

@Patag
Copy link
Author

Patag commented Jul 3, 2020

No gcodes are sent at all

@ellensp
Copy link
Contributor

ellensp commented Jul 3, 2020

Confirmed on a standard ramps current bugfix. Only config changes was to enable a REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and set TEMP_SENSOR_0 999

@ellensp
Copy link
Contributor

ellensp commented Jul 4, 2020

Seem to have been introduced int this commit. c43bbcc

@ellensp
Copy link
Contributor

ellensp commented Jul 4, 2020

See the PR for how to get around this issue.

@Patag
Copy link
Author

Patag commented Jul 4, 2020

Works great. Thank you. Do you want me to close this issue or do we wait for official merge ?

@sjasonsmith
Copy link
Contributor

@Patag I suggest you wait for the PR to merge.

@sjasonsmith
Copy link
Contributor

Ideally you would re-test after the merge to be sure it is fixed. Sometimes PRs change during the PR process and are merged before bugs are found.

@Patag
Copy link
Author

Patag commented Jul 4, 2020

OK

@setar
Copy link
Contributor

setar commented Jul 4, 2020

8a594fc - Not fixed all problem:
I have the same bug, MSG_ERR_MAXTEMP on E1
But i not use 999 and 998 sensors .

#define TEMP_SENSOR_0 1047
#define TEMP_SENSOR_1 0
--skip--
#define TEMP_SENSOR_BED 1
#define TEMP_SENSOR_PROBE 0
#define TEMP_SENSOR_CHAMBER 13

#define TEMP_BED_PIN P0_23_A0 // A0 (TH1)
#define TEMP_0_PIN P0_24_A1 // A1 (TH2)
#define TEMP_CHAMBER_PIN P0_25_A2 // A2 (TH3)

setar_conf_bf.20x.zip

UPDATE:
Sorry the different problem, but similar.
reproduced with 1047 , 1010 and other sensor, where used "PtLine" temp define.

UPDATE2:
reproduced also with 1000 (Custom Thermistor)

#define TEMP_SENSOR_0 1000

#if TEMP_SENSOR_0 == 1000
#define HOTEND0_PULLUP_RESISTOR_OHMS 4700 // Pullup resistor
#define HOTEND0_RESISTANCE_25C_OHMS 1097 // Resistance at 25C // pt1000 = 1097,40 Ohm
#define HOTEND0_BETA 3850 // Beta value //pt1000 = 3850
#endif

@sjasonsmith
Copy link
Contributor

sjasonsmith commented Jul 5, 2020

@setar, please do not add your unrelated issue to this one. This issue is specific to simulated sensors 998 and 999.

@Patag, this has now been merged. There were some changes made prior to merging, so you may want to re-test it before closing the issue.

@ellensp
Copy link
Contributor

ellensp commented Jul 6, 2020

I have just retested with merged changes. They work fine.
So i'm closing this.
@setar If your unrelated issues still persists then please open a new issue.

@github-actions
Copy link

github-actions bot commented Sep 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants