Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Example import-2.0.x/config/examples/Mks/Robin doesn't compile on bugfix. Undefined pins #19501

Closed
ellensp opened this issue Sep 24, 2020 · 1 comment

Comments

@ellensp
Copy link
Contributor

ellensp commented Sep 24, 2020

Bug Description

Provided Configs for MKS Robin does not compile on current bugfix (using platfomio)
Error: 'FSMC_CS_PIN' was not declared in this scope

My Configurations

Configuration.zip

Steps to Reproduce

  1. Download marlin bugfix
  2. apply Config files and platformio.ini from attached Configuration.zip (Same as import-2.0.x/config/examples/Mks/Robin)
  3. Attempt to compile.

Expected behavior:

It should compile

Actual behavior:

Compile fails with this error:

Marlin/src/HAL/STM32F1/tft/tft_fsmc.cpp: In static member function 'static void TFT_FSMC::Init()':
Marlin/src/HAL/STM32F1/tft/tft_fsmc.cpp:89:16: error: 'FSMC_CS_PIN' was not declared in this scope
   uint8_t cs = FSMC_CS_PIN, rs = FSMC_RS_PIN;
                ^~~~~~~~~~~
Marlin/src/HAL/STM32F1/tft/tft_fsmc.cpp:89:16: note: suggested alternative: 'FSMC_CS_NE4'
   uint8_t cs = FSMC_CS_PIN, rs = FSMC_RS_PIN;
                ^~~~~~~~~~~
                FSMC_CS_NE4
Marlin/src/HAL/STM32F1/tft/tft_fsmc.cpp:118:11: error: 'rs' was not declared in this scope
   switch (rs) {
           ^~
Marlin/src/HAL/STM32F1/tft/tft_fsmc.cpp:118:11: note: suggested alternative: 'cs'
   switch (rs) {
           ^~
           cs

Additional Information

Issue is in pins_MKS_ROBIN.h block of code with the define is not active.

@ellensp ellensp changed the title Example import-2.0.x/config/examples/Mks/Robin doesn't compile on bugfix. Undefined pins [BUG] Example import-2.0.x/config/examples/Mks/Robin doesn't compile on bugfix. Undefined pins Sep 24, 2020
ellensp pushed a commit to ellensp/Marlin that referenced this issue Sep 25, 2020
@ellensp ellensp closed this as completed Sep 26, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant