[BUG] "power.cpp" fails to compile if board does not have PS_ON_PIN

[marciot]

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

The "power.cpp" file generates compilation errors if PS_ON_PIN and PSU_POWERUP_DELAY if the board does not support the feature.

It seems like the "power.cpp" file needs a guard condition on whether that feature is available.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.0.x branch

Printer model

Unreleased Prototype Printer

Electronics

Ultimachine Archim 2 board

Add-ons

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

Configuration files:

configuration.zip

Compilation errors:

compilation_errors.txt

[slowbro]

I'm not able to reproduce this with your configs (in fact, the configs fail compilation for a number of other reasons). I tried to replicate it in other ways, i.e. enabling PSU_CONTROL with PS_ON_PIN unset, or set to -1, and it was properly caught with a error: #error "PSU_CONTROL requires PS_ON_PIN.". Make sure that your platformio.ini & ini/features files are up to date, as the most recent version excludes the power.cpp file unless PSU_CONRTOL is enabled.

[marciot]

@slobro: Thank you for this information, you actually explained the situation and gave me the hint I needed on how to fix it.

I am using the Makefile for compilation, not platform.io, so every file gets compiled. This was the way Marlin used to work prior to the switch to platform.io. Because few people use the Makefile anymore, the proper #ifdef guards often aren't updated.

I think I am the only one who uses or tests that, so I'll create a PR to take care of the problem.

[slowbro]

Ah, that makes sense. Glad I could point you in the right direction!

[slobro]

You're welcome. Op wo 14 jul. 2021 17:40 schreef Marcio T. ***@***.***>:

…

@slobro <https://github.com/slobro>: Thank you for this information, you actually explained the situation and gave me the hint I needed on how to fix it. I am using the Makefile for compilation, not platform.io, so every file gets compiled. This was the way Marlin used to work prior to the switch to platform.io. Because few people use the Makefile anymore, the proper #ifdef guards often aren't updated. I think I am the only one who uses or tests that, so I'll create a PR to take care of the problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22353 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7SOUXZVZQLZ6IZIROGTSDTXWVX7ANCNFSM5AJVD65A> .

[thisiskeithb]

Fixed in #22361

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.