RC7 - MINTEMP not triggered

[ViperWorx]

Hi,

I've just put RC7 on one of my Migbot Prusa i3s. While swapping out the layer fan I managed to break the thermistor lead, however MINTEMP wasn't triggered. I can't see any particular updates since it was downloaded on the 13th, I've just got around to configuring it now.

All thermal protections are set.

Configs:
http://pastebin.com/JKnEyqvr - configuration.h
http://pastebin.com/vva6eLCQ - configuration_adv.h

Machine runs a MKS Base 1.2, but is set to RAMPS 1.4 EFB as it's quicker to configure the extruder fan using pin 7 that way (E1 on the MKS).

I can't see any issues with the config and apart from that the printer is working fine.

[thinkyhead]

We received a request not to throw the error until you set the temperature to non-zero. See if you get an error when you set the temperature.

[ghost]

I've perceived that MINTEMP Error isn't thrown when any thermistor isn't connected, since RC7. RC6 throw error.
Is this intended behavior?

[Blue-Marlin]

Yes. That was one of the changes made necessary by the support for high temperature thermistors.
#4698 (comment)

[ghost]

high temp... ah, maybe this. #4244 (Dyze High Temp Thermistor Support)
I see, thanks for the teaching.

[Blue-Marlin]

https://github.com/MarlinFirmware/Marlin/blob/RCBugFix/Marlin/temperature.cpp#L1783-L1792`
and the folowing bloks for the other heaters.
&& target_temperature[0] > 0.0f

I also tripped in that trap (RCBugFix: MINTEMP error broken #4396)

[Blue-Marlin]

Very ugly code.
Maybe something like:

constexpr int temp_direction[EXTRUDERS] = {
  #if HEATER_0_RAW_LO_TEMP > HEATER_0_RAW_HI_TEMP
    -1
  #else
    1
  #endif
  #if HAS_TEMP_1 && HOTENDS > 1
    #if HEATER_1_RAW_LO_TEMP > HEATER_1_RAW_HI_TEMP
      , -1
    #else
      , 1
    #endif
  #endif
  . . .
}; // end temp_direction array 

HOTEND_LOOP() {
  if (temp_direction[e] * current_temperature_raw[e] >= temp_direction[e] * maxttemp_raw[e]) max_temp_error(e);
  if (temp_direction[e] * minttemp_raw[e] >= temp_direction[e] * current_temperature_raw[e] && !is_preheating(e) && target_temperature[e] > 0.0f) {
...
}

could be less ugly.

EDITED

[thinkyhead]

@Blue-Marlin I like your solution to the ugly code. I might have to go that way.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.