Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix 1.1.x] VS Code support for Auto Build #11015

Merged
merged 1 commit into from
Jun 13, 2018
Merged

[bugfix 1.1.x] VS Code support for Auto Build #11015

merged 1 commit into from
Jun 13, 2018

Conversation

Bob-the-Kuhn
Copy link
Contributor

This is the bugfix 1.1.x version of PR #11014.

The changes are exactly the same as in PR #11014. See that PR for details.

@thinkyhead thinkyhead force-pushed the VS-code-1.1.x branch 9 times, most recently from 012fb1b to 67eb7eb Compare June 13, 2018 23:37
@thinkyhead
Copy link
Member

thinkyhead commented Jun 13, 2018 •
edited
Loading

The only way I could get this working was to relocate src/extension.ts to extension.js and change it to Javascript. After that change it works great! Loads up the Tk interface and everything.

Since the README.md is viewed from within VSCode I removed the install VSCode step.

@thinkyhead thinkyhead merged commit c28d2e9 into MarlinFirmware:bugfix-1.1.x Jun 13, 2018
thinkyhead pushed a commit that referenced this pull request Sep 22, 2018
@Bob-the-Kuhn @thinkyhead
Auto Build for Visual Studio Code (#11015)
3c260b2
@Bob-the-Kuhn Bob-the-Kuhn deleted the VS-code-1.1.x branch April 13, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Configurations PR: Improvement PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bob-the-Kuhn @thinkyhead