V1.3.1 hephestos

[jpralves]

It seems that the function lcd_sdcard_stop() - Called by the LCD "Stop Print" function - in file ultralcd.cpp is driving the X or Y axis to the far end due to this code:

+ #if X_MAX_POS < 250
+ plan_buffer_line(X_MIN_POS, 150, current_position[Z_AXIS]+20, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #else
+ plan_buffer_line(X_MAX_POS-15, Y_MAX_POS-15, Z_MAX_POS-15, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #endif

Its dangerous and in the case of the Hephestos should be removed. I've seen this behaviour several times in my Printer.

[jpralves]

It seems that the function lcd_sdcard_stop() - Called by the LCD "Stop Print" function - in file ultralcd.cpp is driving the X or Y axis to the far end of Prusa i3 Hephestos - due to this code:

+ #if X_MAX_POS < 250
+ plan_buffer_line(X_MIN_POS, 150, current_position[Z_AXIS]+20, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #else
+ plan_buffer_line(X_MAX_POS-15, Y_MAX_POS-15, Z_MAX_POS-15, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #endif

Its dangerous and in the case of the Hephestos should be removed. I've seen this behaviour several times in my Printer.

[alexborro]

It is a nice fix.

Could you please submit just the fix to main branch??

Cheers.

Alex.

2014-11-06 10:28 GMT-06:00 João Alves [email protected]:

In Marlin/ultralcd.cpp:

 quickStop();

• #if X_MAX_POS < 250

It seems that the function lcd_sdcard_stop() - Called by the LCD "Stop
Print" function - in file ultralcd.cpp is driving the X or Y axis to the
far end of Prusa i3 Hephestos - due to this code:

• #if X_MAX_POS < 250
• plan_buffer_line(X_MIN_POS, 150, current_position[Z_AXIS]+20, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
• #else
• plan_buffer_line(X_MAX_POS-15, Y_MAX_POS-15, Z_MAX_POS-15, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
• #endif

Its dangerous and in the case of the Hephestos should be removed. I've
seen this behaviour several times in my Printer.

—
Reply to this email directly or view it on GitHub
https://github.com/ErikZalm/Marlin/pull/1135/files#r19955272.

"Não é o mais forte da espécie que sobrevive, nem o mais inteligente. É
aquele que se adapta melhor as mudanças" ( Charles Darwin )

Alex Borro

[galexander1]

The commits in your pull request don't seem related to your comment -- I
think they are based on a different branch than the ErikZalm/Marlin one.

Also, the X-movement code you are concerned about does not seem to be
part of ErikZalm/Marlin. I think it was probably added specifically for
the witbox or hephestos project.. I agree, though, that it looks like a
bad idea. If anything, 'stop print' should probably just move "up" a bit
(positive Z).

On Thu, Nov 06, 2014 at 08:08:34AM -0800, João Alves wrote:

It seems that the function lcd_sdcard_stop() - Called by the LCD "Stop Print" function - in file ultralcd.cpp is driving the X or Y axis to the far end due to this code:

+ #if X_MAX_POS < 250
+ plan_buffer_line(X_MIN_POS, 150, current_position[Z_AXIS]+20, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #else
+ plan_buffer_line(X_MAX_POS-15, Y_MAX_POS-15, Z_MAX_POS-15, current_position[E_AXIS], manual_feedrate[X_AXIS]/60, active_extruder);
+ #endif

Its dangerous and in the case of the Hephestos should be removed. I've seen this behaviour several times in my Printer.

You can merge this Pull Request by running:

git pull https://github.com/bq/Marlin v1.3.1_hephestos

Or you can view, comment on it, or merge it online at:

https://github.com/ErikZalm/Marlin/pull/1135

-- Commit Summary --

• Added Witbox printer changes:
• Release v1.3.1 for bq Witbox
• Release v1.3.1 for bq Hephestos

-- File Changes --

M Marlin/Configuration.h (119)
M Marlin/Configuration_adv.h (24)
M Marlin/Makefile (6)
M Marlin/Marlin.h (3)
M Marlin/Marlin_main.cpp (3293)
M Marlin/Sd2Card.cpp (84)
M Marlin/Sd2Card.h (2)
T Marlin/createTemperatureLookupMarlin.py (0)
M Marlin/digipot_mcp4451.cpp (5)
M Marlin/language.h (1684)
M Marlin/pins.h (122)
M Marlin/stepper.cpp (25)
M Marlin/temperature.cpp (11)
M Marlin/thermistortables.h (244)
M Marlin/ultralcd.cpp (879)
M Marlin/ultralcd.h (14)
M Marlin/ultralcd_implementation_hitachi_HD44780.h (2)
M README.md (3)

-- Patch Links --

https://github.com/ErikZalm/Marlin/pull/1135.patch
https://github.com/ErikZalm/Marlin/pull/1135.diff

---

Reply to this email directly or view it on GitHub:
https://github.com/ErikZalm/Marlin/pull/1135

[jpralves]

Yup. I've seen my mistake I'll provide a nicer patch to the proper branch.