Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] Optional ADC_KEYPAD pin with ANET_10 #13158

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

7eggert
Copy link
Contributor

@7eggert 7eggert commented Feb 13, 2019

… Encoder

Neither overwrite nor set:

  1. LCD_PINS_* if LCD_I2C_TYPE_PCF8575 is set
  2. BTN_EN1, BTN_EN1 If BTN_EN1 is set
  3. BTN_ENC if set
  4. ADC_KEYPAD_PIN if set

Benefits

This allows adding a rotary encoder to Anet A8 with LCD2004 by using a PCF8575 to free some pins

7eggert and others added 3 commits February 13, 2019 15:58
…ncoder

Neither overwrite nor set:

1) LCD_PINS_* if LCD_I2C_TYPE_PCF8575 is set
2) BTN_EN1, BTN_EN1 If BTN_EN1 is set
3) BTN_ENC if set
4) ADC_KEYPAD_PIN if set
@thinkyhead
Copy link
Member

Marlin 1.1.x is end-of-life and won't get any new releases, so you should focus on Marlin bugfix-2.0.x going forward.

@thinkyhead thinkyhead merged commit 369d756 into MarlinFirmware:bugfix-1.1.x Feb 14, 2019
@thinkyhead thinkyhead changed the title pins_ANET_10.h: omit re-defining pins for custom LCD I²C-LCD2004 or … [1.1.x] Optional ADC_KEYPAD pin with ANET_10 Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants