Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix-1.1.x] missing quotation marks #13424

Merged
merged 1 commit into from
Mar 18, 2019
Merged

[Bugfix-1.1.x] missing quotation marks #13424

merged 1 commit into from
Mar 18, 2019

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Mar 17, 2019

No description provided.

@boelle
Copy link
Contributor

boelle commented Mar 17, 2019

you should send pr to Bugfix-2.0.x

this is where things happen these days

@Ludy87
Copy link
Contributor Author

Ludy87 commented Mar 18, 2019

@boelle das würde keinen Sinn machen, der Fehler ist in der bugfix-1.1.x

@boelle
Copy link
Contributor

boelle commented Mar 18, 2019

Nein, du hast recht

Viele Leute vergessen einfach, dass Bugfix-2.0.x sowohl 8-Bit als auch 32-Bit ist

@thinkyhead thinkyhead merged commit 1b5f148 into MarlinFirmware:bugfix-1.1.x Mar 18, 2019
@thinkyhead
Copy link
Member

@boelle — It is better if you write no comments rather than incorrect comments on PRs.

@boelle
Copy link
Contributor

boelle commented Mar 18, 2019

i see nothing wrong, but then again you could have told me on discord and i could have removed the comments

@Ludy87
Copy link
Contributor Author

Ludy87 commented Mar 19, 2019

It's all right.😊 Everyone can make a mistake.

@Ludy87 Ludy87 deleted the bf_1_language_missing branch March 26, 2019 08:33
thinkyhead pushed a commit that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants