Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foolproof hotend offset editing #13669

Conversation

InsanityAutomation
Copy link
Contributor

Opening a little early as it has an overlapping fix with @Ludy87

Hasnt been tested on hardware yet, thats tomorrows plan! I also plan to add some logic around the z softendstop and hotend offset clamp similar to the probe minimum allowance to go below.

@thinkyhead This contains the flip in the section of logic that it looked to me like the condition was inverted in motion.cpp for you to review.

@Ludy87
Copy link
Contributor

Ludy87 commented Apr 12, 2019

@InsanityAutomation

then ignore my PR and use your branch, ok?

@InsanityAutomation
Copy link
Contributor Author

@Ludy87 Not really a big deal either way to me, its up to Scott but figured id at least show what I meant since I had already made the same change offline awhile ago. All this really does differently from yours is add the lines in after config_adv is processed instead of before.

@Ludy87
Copy link
Contributor

Ludy87 commented Apr 12, 2019

Just wanted to agree with your change, Scott knows my Rush PRs 🤣

@InsanityAutomation
Copy link
Contributor Author

@Ludy87 LOL sounds good. I usually try to test everything on my end so sometimes things sit for a few days before I open a PR with em.... Unless im in a hurry on something ;-P

@thinkyhead
Copy link
Member

Rebased.

git fetch origin
git checkout OffsetClamping
git reset --hard origin/OffsetClamping

@InsanityAutomation
Copy link
Contributor Author

Ill add clamping for babystepping tomorrow...

@thinkyhead thinkyhead changed the title Add clamping for hotend offsets Idiot-proof hotend offset editing Apr 22, 2019
@InsanityAutomation
Copy link
Contributor Author

Last comit there is just an idea of where im going. Havnt even made sure x/y hotend offset application is in the right direction.... Out of time right now but figured id let you see where im going.

@boelle
Copy link
Contributor

boelle commented Jul 21, 2019

@thinkyhead this one is failing too

@InsanityAutomation
Copy link
Contributor Author

@boelle this one was mainly a concept to discuss not a completed code change. I'll circle back to it in awhile

@boelle
Copy link
Contributor

boelle commented Jul 21, 2019

hehe, i just saw the fail and wanted to raise some attention keep the hard working people without enough time on their toes :-D

@thinkyhead
Copy link
Member

I like the concept of doing a simple interface on the LCD where you align each tool to a spot on the bed, and then set it that way. In the same process you could also tune the Z probe offset.

@InsanityAutomation
Copy link
Contributor Author

I like the concept of doing a simple interface on the LCD where you align each tool to a spot on the bed, and then set it that way. In the same process you could also tune the Z probe offset.

Originally this was looked at as the first step in helpers to bring M425 into function for IDEX which would do exactly that. Alas priority shifted for interested parties so my efforts have been sidetracked for the time being.

Co-Authored-By: InsanityAutomation <[email protected]>
@thinkyhead
Copy link
Member

Did rebase, squash, clean up, and modernize…

git fetch origin
git checkout OffsetClamping
git reset --hard origin/OffsetClamping

if (offs > hotend_offset[active_extruder].y + hotend_offset_limit.y)
offs = -hotend_offset_limit.y - zprobe_zoffset;
else if (offs < hotend_offset[active_extruder].y - hotend_offset_limit.y)
offs = hotend_offset_limit.y - hotend_offset[active_extruder].y;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rearranged the comparisons to put offs in front of the compare operator. Please validate these changes.

@thinkyhead thinkyhead changed the title Idiot-proof hotend offset editing Foolproof hotend offset editing Oct 11, 2019
@boelle
Copy link
Contributor

boelle commented Oct 12, 2019

the idea of doing offsets to a spot on the bed sounds nice :-D

@boelle
Copy link
Contributor

boelle commented Nov 14, 2019

should this not have been merged or does it still need some work?

@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from 9c35a5b to 3dc49fd Compare December 2, 2019 02:53
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from 6a1a2d4 to 022b6b9 Compare January 5, 2020 07:54
@InsanityAutomation InsanityAutomation deleted the OffsetClamping branch January 11, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants