-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foolproof hotend offset editing #13669
Foolproof hotend offset editing #13669
Conversation
then ignore my PR and use your branch, ok? |
@Ludy87 Not really a big deal either way to me, its up to Scott but figured id at least show what I meant since I had already made the same change offline awhile ago. All this really does differently from yours is add the lines in after config_adv is processed instead of before. |
Just wanted to agree with your change, Scott knows my Rush PRs 🤣 |
@Ludy87 LOL sounds good. I usually try to test everything on my end so sometimes things sit for a few days before I open a PR with em.... Unless im in a hurry on something ;-P |
ea880eb
to
8011fd8
Compare
Rebased.
|
b31e21d
to
f98b455
Compare
Ill add clamping for babystepping tomorrow... |
Last comit there is just an idea of where im going. Havnt even made sure x/y hotend offset application is in the right direction.... Out of time right now but figured id let you see where im going. |
67ac13b
to
f2c5740
Compare
@thinkyhead this one is failing too |
@boelle this one was mainly a concept to discuss not a completed code change. I'll circle back to it in awhile |
hehe, i just saw the fail and wanted to raise some attention keep the hard working people without enough time on their toes :-D |
I like the concept of doing a simple interface on the LCD where you align each tool to a spot on the bed, and then set it that way. In the same process you could also tune the Z probe offset. |
Originally this was looked at as the first step in helpers to bring M425 into function for IDEX which would do exactly that. Alas priority shifted for interested parties so my efforts have been sidetracked for the time being. |
7d7439d
to
7ad5208
Compare
53ba9bd
to
d63e0f6
Compare
Co-Authored-By: InsanityAutomation <[email protected]>
c767968
to
ddcd113
Compare
Did rebase, squash, clean up, and modernize…
|
if (offs > hotend_offset[active_extruder].y + hotend_offset_limit.y) | ||
offs = -hotend_offset_limit.y - zprobe_zoffset; | ||
else if (offs < hotend_offset[active_extruder].y - hotend_offset_limit.y) | ||
offs = hotend_offset_limit.y - hotend_offset[active_extruder].y; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rearranged the comparisons to put offs
in front of the compare operator. Please validate these changes.
the idea of doing offsets to a spot on the bed sounds nice :-D |
db40b4d
to
600429a
Compare
should this not have been merged or does it still need some work? |
9c35a5b
to
3dc49fd
Compare
6a1a2d4
to
022b6b9
Compare
Opening a little early as it has an overlapping fix with @Ludy87
Hasnt been tested on hardware yet, thats tomorrows plan! I also plan to add some logic around the z softendstop and hotend offset clamp similar to the probe minimum allowance to go below.
@thinkyhead This contains the flip in the section of logic that it looked to me like the condition was inverted in motion.cpp for you to review.