Fix G2/G3 workspace plane parameters #15475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_misc_patch_aug10
branch
from
b0c6bc7
to
bf51350
Compare
thinkyhead
force-pushed
the
bf2_misc_patch_aug10
branch
from
bf51350
to
fdb5a25
Compare
rolkun
pushed a commit
to rolkun/Marlin
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #14745….
When using different Workspace Planes the
IJKparameters should correspond to theXYZplanes. Thus in XY orientation, you useIJ, but inYZorientation it'sJK, andZXusesKI.This PR brings
G2/G3into line with the expected behavior.