Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup warnings #1717

Merged
merged 4 commits into from
Mar 28, 2015
Merged

Fixup warnings #1717

merged 4 commits into from
Mar 28, 2015

Conversation

thinkyhead
Copy link
Member

I added -Wall to the compiler flags to generate warnings and went through the code patching them up, testing all but 2 of the included example configurations.

  • Add #undef in several pins files and elsewhere
  • Wrap unused variables and functions in conditionals
  • Fix signed/unsigned comparisons
  • Include 4th temp sensor in conditional for preheat menu items

@thinkyhead
Merge branch 'Development' into fixup_warnings
29a713e 
Conflicts:
	Marlin/Marlin_main.cpp
thinkyhead added a commit that referenced this pull request Mar 28, 2015
@thinkyhead
Merge pull request #1717 from thinkyhead/fixup_warnings
f47fc87 
Fixup warnings
@thinkyhead thinkyhead merged commit f47fc87 into MarlinFirmware:Development Mar 28, 2015
@thinkyhead thinkyhead deleted the fixup_warnings branch March 30, 2015 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead