Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G76 Fix probe height and position #17392

Conversation

Tor-p
Copy link
Contributor

@Tor-p Tor-p commented Apr 3, 2020

Fix probe height for heating which had got lost during code cleanup.
Also added Z_SAFE_HOMING support

Requirements

A z probe with a temperature sensor

Description

When heating the z probe it should be at 0.5 millimeter. This had gotten lost during code cleanup.
It now also respects Z_SAFE_HOMING.
I also changed the config for PTC_MAX_BED_TEMP to BED_MAXTEMP - 10 since that is the highest thermalManager.setTargetBed alows

Benefits

G76 now works

Related Issues

Fix probe height for heating which had got lost during code cleanup.
Also added Z_SAFE_HOMING support
@thinkyhead thinkyhead force-pushed the G76-fix-probe-heating-height-and-position branch 3 times, most recently from d371b05 to 97ea510 Compare April 3, 2020 20:43
@thinkyhead
Copy link
Member

thinkyhead commented Apr 3, 2020

If the user wants to wait-for-heatup and probe at the same point where safe homing occurs, they should set PTC_PROBE_POS_X and PTC_PROBE_POS_Y to that point. There's no reason to override their choice in the case of safe homing.

@thinkyhead thinkyhead force-pushed the G76-fix-probe-heating-height-and-position branch from 9d9e5e1 to f1b2eec Compare April 3, 2020 21:29
@thinkyhead thinkyhead force-pushed the G76-fix-probe-heating-height-and-position branch from f1b2eec to 649cce0 Compare April 3, 2020 21:32
@thisiskeithb
Copy link
Member

thisiskeithb commented Apr 3, 2020

What about removing PTC_MAX_BED_TEMP from Configuration_adv.h all together and use the value from BED_MAXTEMP?

I don't understand the use case where those would need to be different.

@thinkyhead
Copy link
Member

The PTC_MAX_BED_TEMP was added specifically so that it could be set separately. Someone wants it.

@thisiskeithb
Copy link
Member

The PTC_MAX_BED_TEMP was added specifically so that it could be set separately. Someone wants it.

Sort of. I think the @tompe-proj just wanted to make sure it was set correctly:

Could this be derived from MAX_BED_TEMP?

Yes, assuming users set MAX_BED_TEMP correctly in firmware, i.e. the bed can actually reach that temperature. Otherwise they will run into temperature errors while calibrating

Link to comment

@thinkyhead thinkyhead merged commit d6f39a6 into MarlinFirmware:bugfix-2.0.x Apr 6, 2020
DerAndere1 pushed a commit to DerAndere1/Marlin that referenced this pull request Apr 9, 2020
ghost pushed a commit to bfhobbes/Marlin that referenced this pull request Apr 15, 2020
mathom pushed a commit to mathom/Marlin that referenced this pull request Apr 17, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants