Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup fixes for SINGLENOZZLE, etc. #17712

Merged
merged 14 commits into from
Apr 28, 2020
Merged

Followup fixes for SINGLENOZZLE, etc. #17712

merged 14 commits into from
Apr 28, 2020

Conversation

studiodyne
Copy link
Contributor

@studiodyne studiodyne commented Apr 25, 2020 •
edited
Loading

LCD

  • Lcd corrupted fanspeed display (old bug )
  • Single nozzle stored temps menu, for all extruders

TOOL_CHANGE

  • Mistakes
  • On migration, no toolchange temp/fanspeed management (only by migration)
  • Gcode.dwell instead of safedelay 'fanspeed issue'
  • T0 first used priming only , if others , then toolchange() make change + priming
  • In cfg.h SINGLE_NOZZLE: Add option 'stored values' (Usually managed by slicer, need to reprofile slicer if temp/fanspeed low down on tool change)

AUTOTEMP

  • AUTOTEMP updating values for single nozzle stored temps, in toolchange
  • AUTOTEMP updating values for migration

XY_FREQUENCY_LIMIT

  • Fix lcd edit menu 'compile error'
  • Fix (*100) error in menu

@studiodyne studiodyne changed the title Fixtoolchange [Fix} Fixes for toolchange (in progress/not finished) Apr 25, 2020
@studiodyne studiodyne force-pushed the fixtoolchange branch 7 times, most recently from 87bb57e to 2396c4c Compare April 26, 2020 12:50
@studiodyne studiodyne changed the title [Fix} Fixes for toolchange (in progress/not finished) [Fix} Fixes for toolchange (tests in progress) Apr 26, 2020
@studiodyne studiodyne force-pushed the fixtoolchange branch 2 times, most recently from 3365817 to f7a901f Compare April 26, 2020 13:18
@studiodyne studiodyne changed the title [Fix} Fixes for toolchange (tests in progress) [Fix} Fixes : LCD/TOOLCHANGE/AUTOTEMP Apr 26, 2020
@studiodyne studiodyne changed the title [Fix} Fixes : LCD/TOOLCHANGE/AUTOTEMP [Fix] Fixes : LCD/TOOLCHANGE/AUTOTEMP Apr 26, 2020
@studiodyne studiodyne force-pushed the fixtoolchange branch 3 times, most recently from f7f2fa9 to d9a26cd Compare April 26, 2020 13:58
@studiodyne studiodyne closed this Apr 26, 2020
@studiodyne studiodyne reopened this Apr 26, 2020
@studiodyne studiodyne force-pushed the fixtoolchange branch 5 times, most recently from 1807801 to d0fcb4a Compare April 26, 2020 16:09
@studiodyne studiodyne changed the title [Fix] Fixes : LCD/TOOLCHANGE/AUTOTEMP [Fix] LCD/TOOLCHANGE/AUTOTEMP Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP [Fix] LCD/TOOLCHANGE/AUTOTEMP (ready and tests ok) Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP (ready and tests ok) [Fix] LCD/TOOLCHANGE/AUTOTEMP Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP [Fix] LCD/TOOLCHANGE/AUTOTEMP (ready) Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP (In progress) [Fix] LCD/TOOLCHANGE/AUTOTEMP Apr 27, 2020
@thinkyhead
Copy link
Member

may be you can take a look

Ya think?

@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP [Fix] LCD/TOOLCHANGE/AUTOTEMP +Fix XY_FREQUENCY_LIMIT 'compile error' Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP +Fix XY_FREQUENCY_LIMIT 'compile error' [Fix] LCD/TOOLCHANGE/AUTOTEMP Apr 27, 2020
@studiodyne studiodyne changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP [Fix] LCD/TOOLCHANGE/AUTOTEMP/XY_FREQUENCY_LIMIT Apr 27, 2020
@studiodyne studiodyne force-pushed the fixtoolchange branch 2 times, most recently from d201021 to fa7260a Compare April 27, 2020 16:01
@thinkyhead thinkyhead merged commit 89b17b5 into MarlinFirmware:bugfix-2.0.x Apr 28, 2020
@thinkyhead thinkyhead changed the title [Fix] LCD/TOOLCHANGE/AUTOTEMP/XY_FREQUENCY_LIMIT Followup fixes for SINGLENOZZLE, etc. Apr 28, 2020
@studiodyne studiodyne deleted the fixtoolchange branch April 28, 2020 09:18
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
@studiodyne
Followup fixes for singlenozzle, etc. (MarlinFirmware#17712)
b1383db
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
@studiodyne
Followup fixes for singlenozzle, etc. (MarlinFirmware#17712)
933781c
This was referenced Aug 26, 2020
Closed
Merged
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
@studiodyne @HairingX
Followup fixes for singlenozzle, etc. (MarlinFirmware#17712)
98815de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkyhead thinkyhead thinkyhead left review comments

Assignees
No one assigned
Labels
C: Temperatures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@studiodyne @thinkyhead