Fix for SD card pause not working with PARK_HEAD_ON_PAUSE #17754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
in my case this merge create an issue : |
Apparently the correct solution was to make some changes to |
|
@spilz87 — Are you using |
|
Yes I am |
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently SD card pause is not working with PARK_HEAD_ON_PAUSE. On further investigation, I determined that this was because M25 is pre-maturely pausing the SD print prior to calling M125. M125 then checks whether an SD print is running and takes the wrong code execution path because it finds the print is already paused,
This PR modified the code to pass control directly to M125 when PARK_HEAD_ON_PAUSE is enabled.
Benefits
Now it is possible to pause a print without having it immediately restart.