Fix LCD_TIMEOUT_TO_STATUS bug #17887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
added a commit
that referenced
this pull request
May 6, 2020
Replaces #17887 Co-Authored-By: Daniel Callander <[email protected]>
|
Thanks! The patch is now applied, but in a different manner so that you can set |
thinkyhead
changed the title
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Replaces MarlinFirmware#17887 Co-Authored-By: Daniel Callander <[email protected]>
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
Replaces MarlinFirmware#17887 Co-Authored-By: Daniel Callander <[email protected]>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Replaces MarlinFirmware#17887 Co-Authored-By: Daniel Callander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove checks for
LCD_TIMEOUT_TO_STATUSas it always gets set inConditionals_post.h.Benefits
Removes unneeded
#ifandTERNguards.Related Issues
This will fix #17883 and #17885 since there will be no
TERNanymore. :)Specifically: deferring the return to status screen is totally broken right now. Any modal will always get returned to the status screen eventually (i.e., bed leveling corner.)
The core problem with the above issues is that
TERNbreaks becauseLCD_TIMEOUT_TO_STATUSexpands to a value rather than being empty. This doesn't solve the issue withTERNas it just gets rid of it entirely, but it does solve the timeout issue.