Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loops in SERIAL_ECHOLNPAIR and SERIAL_ECHOLNPAIR_P #17932

Merged
merged 1 commit into from
May 10, 2020

Conversation

sjasonsmith
Copy link
Contributor

Description

Recent increases to the number of arguments handled by serial printing macros introduced infinite loops.

Benefits

Fixes infinite printing and watchdog resets when enabling M115_GEOMETRY_REPORT. I suspect that is the only feature using this many arguments.

Related Issues

#17922

@thinkyhead
Copy link
Member

Betrayed by one of my favorite editor plugins.

@thinkyhead thinkyhead merged commit 209fd2d into MarlinFirmware:bugfix-2.0.x May 10, 2020
@sjasonsmith sjasonsmith deleted the PR/SERIAL_HANG branch May 10, 2020 05:11
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants