Fix blue in NEOPIXEL_STARTUP_TEST #19156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Aug 28, 2020
…K8800-2.0.x * tag '2.0.6.1' of https://github.com/MarlinFirmware/Marlin: (195 commits) Version 2.0.6.1 [cron] Bump distribution date (2020-08-28) Add set_all_homed Mark axes not-homed with HOME_AFTER_DEACTIVATE (MarlinFirmware#18907) set_axis_not_trusted => set_axis_never_homed Independent Neopixel option (MarlinFirmware#19115) Fix Creality V4 probe pin Fix small typø Allocate sufficient MSG_MOVE_Z_DIST buffer One MARLIN_DEV_MODE warning per rebuild (MarlinFirmware#19163) FYSETC S6 2.0 (MarlinFirmware#19140) [cron] Bump distribution date (2020-08-27) Fix SINGLENOZZLE fan speed bug (MarlinFirmware#19152) Fix NEOPIXEL_STARTUP_TEST last delay (MarlinFirmware#19156) TFT (plus Hardware SPI) for LPC (MarlinFirmware#19139) Prusa => Průša Direct Stepping update (MarlinFirmware#19135) Fixes to FTDI Touch UI (MarlinFirmware#19134) Add Einsy Rambo Filament Runout Pin (MarlinFirmware#19136) Fix SD pins for SKR Pro and GTR (MarlinFirmware#19047) ...
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Sep 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
A number of NeoPixel LEDS, and enable NEOPIXEL_STARTUP_TEST
Description
Currently the RGB test at startup only displays Red and Green, Blue is missing.
The cause, Blue is being setup but is immediately being followed by setting a new colour;
The setting a new colour is part of the LED_USER_PRESET_STARTUP block. it either sets the neopixels to the preset colour, or all neopixels off. In either case BLUE is overridden.
Added a simple delay so blue can be seen.
Benefits
NEOPIXEL_STARTUP_TEST works as expected.
Related Issues
Noticed this while looking into #19154