ADVANCED_PAUSE not compile without PREVENT_COLD_EXTRUSION (#19463) #19740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ware#19463) Added macro to exclude if on non declared field
Zorchz
pushed a commit
to Zorchz/Marlin-1
that referenced
this pull request
Oct 17, 2020
Zorchz
pushed a commit
to Zorchz/Marlin-1
that referenced
this pull request
Oct 17, 2020
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Oct 21, 2020
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Oct 23, 2020
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Nov 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 8, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 11, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added #if Enabled macro bracketing sensitive if statement that check non undeclared field
thermalManager.targetTooColdToExtrudeIn temerature.h field extrude_min_temp is declared conditionally in respect to PREVENT_COLD_EXTRUSION. This was not changed recently, yet how the ensure_safe_temperature handles this has changed:
2.6.1 no use of the field
2.0.7 and 2.0.x use that field:
https://github.com/MarlinFirmware/Marlin/blob/da79674f84ef65cb014288a27d60f8709b1f0936/Marlin/src/feature/pause.cpp#L136
Benefits
Makes compilation working with Advanced Pause Feature enabled while Prevent Cold Extrusion disabled
Related Issues
#19463