Fix LCD Menus + DAC compilation #19907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not tested this myself, hopefully @fiveangle can verify it, since it is based on their bug report. |
|
Fixes resolves compile failure. Unable to test on printer since it's not near, but based on the fix I don't see it being an issue. |
Merged
|
Hi @sjasonsmith , I also noticed some issues regarding DAC stuff. I have just created a pull request but i guess it is more convenient for reviewers if i integrate it in yours. Do you agree? |
|
@0r31 mine just fixes a minor compilation issue. If yours is not directly related to my changes, I suggest you just post a new PR. |
|
Understood @sjasonsmith , thanks for your update. |
thinkyhead
changed the title
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Nov 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent stepper DAC refactoring missed a related menu item.
After fixing that, I then had the following error, which is why I modified settings.cpp.:
Marlin\src\module\settings.cpp:3794:102: error: #elif with no expressionBenefits
Allows compiling for boards with LCDs and Stepper DACs.
Configurations
Configurations were adapted from bug #19216
Configuration.zip
Related Issues
#19216