Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #20085, POWER_LOSS_RECOVERY assumes fan exists #20096

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Fixes issue #20085, POWER_LOSS_RECOVERY assumes fan exists #20096

merged 2 commits into from
Nov 11, 2020

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Nov 11, 2020 •
edited by thinkyhead
Loading

Requirements

enable POWER_LOSS_RECOVERY
enable SDSUPPORT needed by POWER_LOSS_RECOVERY
define FAN_PIN -1

Description

This will fail to compile with the following error.

Marlin\src\feature\powerloss.cpp: In static member function 'static void PrintJobRecovery::resume()':
Marlin\src\feature\powerloss.cpp:436:13: error: 'i' was not declared in this scope
FANS_LOOP(i) {
^
Marlin\src\feature\powerloss.cpp:436:14: error: 'FANS_LOOP' was not declared in this scope
FANS_LOOP(i) {

Added a #if HAS_FAN block around offending code.

Benefits

This compiles as expected

Related Issues

Issue #20085

@thinkyhead thinkyhead merged commit 7216b8f into MarlinFirmware:bugfix-2.0.x Nov 11, 2020
FhlostonParadise pushed a commit to FhlostonParadise/Marlin that referenced this pull request Nov 21, 2020
@ellensp @FhlostonParadise
Fix compile with PLR, no fan (MarlinFirmware#20096)
5f5f360
Kannix2005 pushed a commit to Kannix2005/Marlin-1 that referenced this pull request Dec 7, 2020
@ellensp @Kannix2005
Fix compile with PLR, no fan (MarlinFirmware#20096)
93d7fd1
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
@ellensp @vgadreau
Fix compile with PLR, no fan (MarlinFirmware#20096)
703f00b
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
@ellensp @tharts
Fix compile with PLR, no fan (MarlinFirmware#20096)
d067b8e
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
@ellensp @dpreed
Fix compile with PLR, no fan (MarlinFirmware#20096)
0ba9200
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
@ellensp @kpishere
Fix compile with PLR, no fan (MarlinFirmware#20096)
d596394
@ellensp ellensp deleted the bugfix-2.0.x-#20085 branch March 8, 2021 00:28
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@ellensp @W4tel-BiDi
Fix compile with PLR, no fan (MarlinFirmware#20096)
606ff0b
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
@ellensp @thinkyhead
Fix compile with PLR, no fan (MarlinFirmware#20096)
5d6052a
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
@ellensp @thinkyhead
Fix compile with PLR, no fan (MarlinFirmware#20096)
81141f5
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
@ellensp @thinkyhead
Fix compile with PLR, no fan (#20096)
ac74786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellensp @thinkyhead