Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Hotend Preheat Fixes #20165

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Nov 16, 2020

Description

Return to Status Screen after using "Preheat (material) All" menu on multi-hotend setups and fix bed preheat with @rhapsodyv's fix below.

Benefits

Return to Status Screen similar to how preheating with a single extruder currently works and preheat the bed when selecting "Preheat (material) All".

Configurations

Use configs from #20163/any multi-hotend setup.

Related Issues

#20163

@rhapsodyv
Copy link
Member

I think I missed something, in a first view. MSG_PREHEAT_M_ALL call _preheat_bed, that call lcd_preheat, that calls ui.return_to_status().
So, if the user have a HAS_HEATED_BED, it should get back to information screen.

Maybe the fix is use the complete TERN(HAS_HEATED_BED, []{ _preheat_bed(editable.int8); }, ui.return_to_status()); and call it after the HOTEND_LOOP.

@rhapsodyv
Copy link
Member

It is a little more strange. TERN_(HAS_HEATED_BED, []{ _preheat_bed(editable.int8); }); just declare a lamba, and don't call it ... I'm almost sure that it won't will heat the bed!

I think the fix is:

        ACTION_ITEM_S(ui.get_preheat_label(m), MSG_PREHEAT_M_ALL, []() {
          HOTEND_LOOP() thermalManager.setTargetHotend(ui.material_preset[editable.int8].hotend_temp, e);
          TERN(HAS_HEATED_BED, _preheat_bed(editable.int8), ui.return_to_status());
        });

Co-authored-by: Victor Oliveira <[email protected]>
@thisiskeithb thisiskeithb changed the title Return to Status Screen on Multi-Hotend Preheat All Multi-Hotend Preheat Fixes Nov 16, 2020
@sjasonsmith sjasonsmith merged commit c12e693 into MarlinFirmware:bugfix-2.0.x Nov 17, 2020
@thisiskeithb thisiskeithb deleted the pr/return-to-status-screen-on-preheat-all branch November 17, 2020 14:04
FhlostonParadise pushed a commit to FhlostonParadise/Marlin that referenced this pull request Nov 21, 2020
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
Kannix2005 pushed a commit to Kannix2005/Marlin-1 that referenced this pull request Dec 7, 2020
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
* Return to Status Screen on Multi-Hotend Preheat All

Co-authored-by: Victor Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants