Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove space from m118 host action response #20600

Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Dec 30, 2020

Requirements

M118 P0 A1 text

Description

Results in "// action:notification text" vs expected "//action:notification text"
This breaks octoprints severely deficient passer.
This removes extra space from response.

Benefits

Works with octoprint and more uniform formatting.

Related Issues

#20594

@sjasonsmith sjasonsmith linked an issue Dec 31, 2020 that may be closed by this pull request
@thinkyhead thinkyhead merged commit 5eaa10e into MarlinFirmware:bugfix-2.0.x Jan 2, 2021
@ellensp ellensp deleted the bugfix-2.0.x-#20594 branch January 2, 2021 08:21
TheMichalcinOfficial added a commit to TheMichalcinOfficial/Marlin that referenced this pull request Jan 4, 2021
* [cron] Bump distribution date (2020-12-31)

* SPI and pins cleanup

* [cron] Bump distribution date (2021-01-01)

* Prefix SD SPI pins (SCK, MISO, MOSI, SS) (MarlinFirmware#20606)

Co-authored-by: Scott Lahteine <[email protected]>

* Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

* Fix CHAMBER_FAN_MODE 0 build (MarlinFirmware#20621)

* [cron] Bump distribution date (2021-01-02)

* Fix UBL mesh edit delta moves (MarlinFirmware#20620)

Co-authored-by: Scott Lahteine <[email protected]>

* Fix //action prefix (MarlinFirmware#20600)

* Assisted Tramming improvements (MarlinFirmware#20298)

* Check for misplaced configs on build (MarlinFirmware#20599)

Co-authored-by: Scott Lahteine <[email protected]>

* Fix a comment (MarlinFirmware#20629)

* Document, adjust some homing code

* Improved bootscreen animation

* [cron] Bump distribution date (2021-01-03)

* Homing code followup (MarlinFirmware#20632)

Patching a87e519

* Animated boot followup

* Add ALL_AXES manual move for UBL mesh editing

Co-Authored-By: Jason Smith <[email protected]>

MarlinFirmware#20620

* Creality 4.2.10 board (MarlinFirmware#20647)

* Update Italian language (MarlinFirmware#20663)

* [cron] Bump distribution date (2021-01-04)

* Fix thermal error protection, reporting (MarlinFirmware#20655)

* Rename FTDI EVE screen data structs

* Fix SD SPI Speed override, FTDI mesh edit (MarlinFirmware#20657)

Co-authored-by: Scott Lahteine <[email protected]>

* Fix IDEX reboot on travel after G28 X (MarlinFirmware#20654)

* Fix delayed_move_time elapsed test

* Move duplication_e_mask

Co-authored-by: thinkyhead <[email protected]>
Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: Victor Oliveira <[email protected]>
Co-authored-by: zeleps <[email protected]>
Co-authored-by: Jason Smith <[email protected]>
Co-authored-by: ellensp <[email protected]>
Co-authored-by: qwewer0 <[email protected]>
Co-authored-by: Giuliano Zaro <[email protected]>
Co-authored-by: Marcio T <[email protected]>
Co-authored-by: InsanityAutomation <[email protected]>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] inconsistent space beetween M117 and M118 hostactions
3 participants