Use _temp_error() for all errors thrown by different heater sanity check mechanisms

[AnHardt]

Now ending in an endless loop.
Tidy up the output format.
We now get:
ERRORTEXT ", system stopped! Heater_ID: " HEATERID

Where ERRORTEXT can be:
"Heating failed"
"Thermal Runaway"
"MAXTEMP triggered"
"MINTEMP triggered"
and soon
"Thermal Jump"

HEATERID can be
0, 1, 2 ,3 , "bed"

This messages are always followed by the common:
"Printer stopped due to errors. Fix the error and use M999 to restart. (Temperature is reset. Set it after restarting)"

[AnHardt]

Addresses mainly the tests ending with 'Heating failed' in #2066.
Ideally you cant come out of this without a reset.
I hope not to break the serial protocol.
With the second line the host is informed about the stop, on the common way.

[thinkyhead]

We should drop M999 with this perhaps. The only other condition that has a full Stop() is when a servo probe fails to deploy or stow.

[scotty1024]

How about M999 says yo home boy you don't need me anymore and drop the command after a decent interval?

On May 18, 2015, at 8:29 PM, Scott Lahteine [email protected] wrote:

We should drop th M999 with this. The only other condition that has a full Stop() is when a servo probe fails to deploy or stow.

—
Reply to this email directly or view it on GitHub.

[clefranc]

Beginning testing now...

[clefranc]

@AnHardt See #2066 for bed results.

There is something definitely wrong with this PR as the thermal jump is not there anymore for the bed.

I don't know if it's revelent to do hotend tests???

[AnHardt]

@clefranc
Ah, i see what happened.
This PR ( _temp_error()) #2115 only alters the behavior when an error was detected. Since you did not get any errors during last tests, you have not tested it at all.
To see the difference of _temp_error() without #2077, just repeat Test 8 (or an other one with "Heating failed") of you test row.

#2077 (Jumps) is the part where the errors are detected. You need #2115 and #2077 at the same time.
If you try to merge them together you'll get a minor merge conflict. Just add the message for 'Jump' in the new style of #2115.

[clefranc]

@AnHardt See #2066 Test 8.

[thinkyhead]

yo home boy you don't need me anymore

Good general principle for anything that might go away.

[AnHardt]

@clefranc
Thank you for the test.
Conclusion: If we detect an error - we are safe now.

[thinkyhead]

@scotty1024 Another option for M999 – Actually reset the board.

void (*ResetAVR)(void) = 0; // Reset function is Address 0
ResetAVR();