Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New colors for Marlin TFT COLOR UI #22002

Closed
wants to merge 3 commits into from
Closed

New colors for Marlin TFT COLOR UI #22002

wants to merge 3 commits into from

Conversation

DvoraNoob
Copy link
Contributor

I added 2 new colors to select in the Marlin Color UI

I did it because I don't like the original colors

I only tested in my MKS ROBIN NANO V2 with MKS TFT35 V2

@rhapsodyv
Copy link
Member

You need to send this PR to bugfix branch, not the 2.0.x one.

Add some photos of the new themes.

One question: why should we support hard coded pre made themes when all the colors (almost at least) can be overwritten by the configuration?

@rhapsodyv
Copy link
Member

See this PR: #19484

@DvoraNoob DvoraNoob changed the base branch from 2.0.x to bugfix-2.0.x May 30, 2021 17:20
@DvoraNoob DvoraNoob changed the base branch from bugfix-2.0.x to 2.0.x May 30, 2021 17:23
@DvoraNoob DvoraNoob changed the base branch from 2.0.x to bugfix-2.0.x May 30, 2021 17:24
@DvoraNoob DvoraNoob changed the base branch from bugfix-2.0.x to 2.0.x May 30, 2021 17:24
@DvoraNoob DvoraNoob closed this May 30, 2021
@DvoraNoob
Copy link
Contributor Author

I did this because it is easier to change colors, and not everyone knows how to change colors in the tft_color.h file, I also put variables that were in other files in tft_color.h, now you can change all colors in tft_color.h

I'll take the photos of the predefined themes and make a pull request again on the Bugfix branch

@rhapsodyv
Copy link
Member

Take a look in the above PR. You don't need to change the colors, but the color "configs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants