BigTreeTech SKR Mini E3 V3.0 #23284
Closed
BigTreeTech SKR Mini E3 V3.0 #23284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Dec 9, 2021
thinkyhead
force-pushed
the
bf2_btt_skr_e3_mini_v3_PR
branch
from
e74a7ad
to
30d94bc
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Dec 9, 2021
|
Ah, we actually submitted same PR at about the same time #23283 |
bigtreetech
reviewed
Dec 9, 2021
| @@ -78,7 +78,9 @@ static SPISettings spiConfig; | |||
| case SPI_SPEED_6: delaySPIFunc = &delaySPI_2000; break; // desired: 250,000 actual: ~210K | |||
| default: delaySPIFunc = &delaySPI_4000; break; // desired: 125,000 actual: ~123K | |||
| } | |||
| SPI.begin(); | |||
| #ifndef STM32G0B1xx | |||
There was a problem hiding this comment.
In fact, this is not for STM32G0B1xx, but for all STM32 software SPI. When I first adapted STM32G0B1xx to Marlin, in order to reduce the impact of Arduino_Core_STM32 library, I used the software SPI and found the problem here, detail in #23064, I think it should be deleted directly here, and I test it in Octopus and SKR-mini-E3-V3.0, but I'm not sure whether it will affect other products, so I didn't submit PR but submit an issue.
SKR-mini-E3-V3.0 use the hardware SPI now. So here for SKR-mini-E3-V3.0 has no effect.
bigtreetech
pushed a commit
to bigtreetech/Marlin
that referenced
this pull request
Dec 9, 2021
thinkyhead
force-pushed
the
bf2_btt_skr_e3_mini_v3_PR
branch
from
30d94bc
to
0289c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen on TV.
Adapted from the branch https://github.com/bigtreetech/Marlin/tree/SKR-mini-E3-V3.0-G0B1