Fix MarlinUI temporary allow cold extrude

[ellensp]

Description

With a display that uses menu_motion.cpp The menu Motion | Move Axis | Move Extruder
Prompts with "Hotend too cold!" when the hotend is to cold, as It should.

This screen has a option to proceed and cold extrude, which did not work.

Was fixed in #24045 until code was modified in 1a7052b

Fixed again here.

Requirements

#define PREVENT_COLD_EXTRUSION
A display that uses menu_motion.cpp

Benefits

Works as expected

Related Issues

#22921

[thinkyhead]

This is here to make sure the flag gets set to false whenever the move screen is exited (so, whenever the screen is changed), otherwise the flag will be stuck in the true state. As long as set_menu_cold_override is called after _goto_menu_move_distance_e the desired result should be achieved (assuming there are no sub-screens).

The call to set_menu_cold_override(false) that's being added to menu_move (below) won't do the trick. It only resets the flag to false in the event the user enters (or returns to) the Move menu, which is not guaranteed. It doesn't handle timeout to status screen or the case of some incoming G-code command changing the screen. Setting it to false here in goto_screen is expected to be totally reliable.

So, we need a better understanding why the current pattern is failing. Where else is the flag getting set to false? Is goto_screen called a second time by some quirk? What does investigation with SERIAL_ECHO (or GDB) tell us?

[thinkyhead]

Using GDB –because why not– it looks like all we need to do is to set the flag a bit later, just after goto-ing the final move screen in _goto_manual_move. If the user has arrived at that point, either the extruder is heated or they clicked "proceed" after the cold extrude warning.

[ellensp]

Still getting "echo: cold extrusion prevented" not always like before, but sometimes.
I can not reliably reproduce this issue.

It happens when you click from move submenu back to main Move Extruder menu