Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a validation check for the BLTouch #25021

Closed
wants to merge 12 commits into from

Conversation

slowbro
Copy link
Member

@slowbro slowbro commented Nov 26, 2022

Description

Checks the status() of the BLTouch when stowed/deployed before homing z and fails homing if they don't differ. Can successfully detect a) unplugged BLTouch probe pins, and b) reversed BLTouch probe pins.

Requirements

BLTOUCH, Z_SAFE_HOMING, BLTOUCH_VALIDATE_ON_HOMING

Benefits

Adds a safety check to homing for unplugged or reversed BLTouch probe wires.

Configurations

See requirements.

Related Issues

#24933

@thinkyhead
Copy link
Member

With probe behavior now moved more into the Probe class, it may make more sense to do the validation check on every initial deploy of the probe, instead of just in the middle of G28 homing of Z.

@cfcgreg
Copy link

cfcgreg commented Sep 14, 2023

I noticed that was used with bug-fix 2.0x. Does it work with 2.1.2.1?

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 2 times, most recently from 9c65146 to 4f65466 Compare January 26, 2024 00:13
@sjasonsmith
Copy link
Contributor

Based on the age of this PR and the lack of response to the last two comments, I'm going to close this out.

@slowbro you are welcome to resubmit this against the current bugfix-2.1.x branch if you are still interested. Per thinkyhead's earlier comment you would want to do that in the Probe class, so it would apply to every deploy of the probe and not only during homing.

Of course given the age of the PR I'm not sure whether this type of capability has already been implemented elsewhere.

@HilariousHam

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants