Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

320x240 LCD portrait mode UI #25191

Closed
wants to merge 2 commits into from
Closed

320x240 LCD portrait mode UI #25191

wants to merge 2 commits into from

Conversation

alexgrach
Copy link
Contributor

Description

320x240 LCD portrait mode UI.

main
move

Requirements

MKS Robin Nano, MKS Robin TFT 2,8"

Benefits

No HW modification is needed for 3D printers with portrait orientation LCD in stock (tested on Kingroon KP3S).

Configurations

Configuration_kp3s.zip

Related Issues

@ellensp
Copy link
Contributor

ellensp commented Jan 5, 2023

Is this the best way to implement this?
There is already #define TFT_ROTATE TFT_ROTATE_90, vs defining a new screen size (not sure if this works at present, but should be made to)

@alexgrach
Copy link
Contributor Author

Are you shure? It should look like this:
#if TFT_ROTATE == TFT_ROTATE_90 || TFT_ROTATE == TFT_ROTATE_90_MIRROR_X || TFT_ROTATE == TFT_ROTATE_90_MIRROR_Y || TFT_ROTATE == TFT_ROTATE_270 || TFT_ROTATE == TFT_ROTATE_270_MIRROR_X || TFT_ROTATE == TFT_ROTATE_270_MIRROR_Y
Maybe it's better add something simular to DWIN display?
#define TFT_COLOR_UI_PORTRAIT

@crazyfrog1
Copy link

Please post a full build I can compile. I had several errors trying to compile from your build
image

@alexgrach
Copy link
Contributor Author

bugfix-2.1.x.zip

@SimoneDallaC
Copy link

Hello. This thing you can also have with a tft35?

@alexgrach
Copy link
Contributor Author

Any 320x240 graphical LCD should work.

@SimoneDallaC
Copy link

Thanks for your answer. Can you help me with some indication to be able to do it also in a tft35?

@ellensp
Copy link
Contributor

ellensp commented Jan 6, 2023

"Any 320x240 graphical LCD should work." where the lcd is controlled by Marlin.
This is not applicable to tfts that are running their own firmware that talk serial.

@thinkyhead
Copy link
Member

@alexgrach — For some reason I cannot merge changes into this PR directly. So, please merge alexgrach#1 at your earliest convenience! There are some more changes, likely, from PR #25073 that might also apply to the 240 x 320 portrait display, so please diff/compare your new files with the 320 x 240 versions to see if any other non-yet-applied changes should be applied. Thanks for the submission! Hopefully we will soon consolidate all the common parts of these different-sized displays –maybe in ui_common.cpp– and reduce the redundancies of these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants