-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make X axis optional (WIP) #25418
Make X axis optional (WIP) #25418
Conversation
I've done all the obvious code, now i'm stuck in "macro hell" Can anyone lend a brain to assist? |
updated the obvious
Set conditional check from Y to X Changed pattern of axis definition to match existing nested pattern
I believe this is essentially impossible given the current Marlin architecture. As a basic point, the type |
a5c4c64
to
4418caa
Compare
529e751
to
b2da2e2
Compare
b2da2e2
to
06f0530
Compare
…or maybe…. Apparently a zero-length array is possible, and maybe empty structs. At any rate, it's now compiling, so that's a pleasant surprise. |
just talking a look at it now, complies, uploads, responds to gcode ... I need to find an extruder I can play with... |
Some hacky stuff was done to the BTT EBB42 pins in #24964 to make Marlin compile without an x/y/z axis, so that should probably get cleaned up here as well: Marlin/Marlin/src/pins/stm32g0/pins_BTT_EBB42_V1_1.h Lines 80 to 93 in d3527f5
|
@thisiskeithb that is part of the plan, but a sperate pr |
27df113
to
8d31429
Compare
@thinkyhead Sorry I found that there was an issue and tried to roll back the PR, it caused an issue that prevented the board from running code when Virtual EEPROM was enabled, presumably caused by memory locations. |
de391db
to
0f34163
Compare
f02cd3e
to
ddd8be4
Compare
As PRs go this one is a biggie! I was holding it until after 2.1.3, which was anticipated to happen a lot sooner. I've merged to bring it up to date, so now it should be tested again to make sure all the basic functions work when there's only an extruder and nothing else. That includes the EEPROM, to see whether the comment above still applies. I don't anticipate any major troubles with this PR generally, but it does continue to lean into the old ways. Once this next release is out the door (and patched up in a followup minor release), we should look at refactoring more in the direction of templates, compiler dead-code stripping, and so on. It would be neat to get more formal object classes like I do want to get 2.1.3 released soon. I just have to re-test the probing and |
… into feature/bugfix-2.1.x * 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin: (302 commits) 🚸 Optional X-Axis (MarlinFirmware#25418) [cron] Bump distribution date (2023-05-09) 🧑💻 PI => M_PI 🧑💻 Extend AxisBits 🐛 Fix babystep corrupting DIR 🔨 MKS Robin2 PIO Env (MarlinFirmware#25792) [cron] Bump distribution date (2023-05-08) 🩹 Creality F401 Followup 🐛 Fix Babystepping for CoreXZ 🩹 Use AxisBits methods [cron] Bump distribution date (2023-05-07) 🩹 Endstops prelim. followup 🚸 Faster default Marlin feedrate 🐛 Apply direction bits at startup 🔧 Apply bootscreen settings to ProUI 🩹 FT Motion prelim followup 🧑💻 Endstops preliminary followup 🐛 Minor Fixed-Time Motion patches 🔧 Allow TMC_BAUD_RATE override 🧑💻 Endstops preliminary work (MarlinFirmware#25780) ... Signed-off-by: Nick Snyder <[email protected]> # Conflicts: # config/ncksnydr/narungol/2.1/Configuration.h # config/ncksnydr/narungol/2.1/Configuration_adv.h
Co-authored-by: alextrical <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Hello all, I believe this or the previous PR in the series broke the backlash menu for XYZE printers, HAS_A_AXIS is now undefined in _CAN_CALI(A) used in menu_backlash.cpp. Since this is WIP apparently, feel free to ignore. Otherwise adding another 3 clauses for X Y Z ( A B ...) looks an obvious quickfix. |
For laser, Z is optional (which my table is manual Z adjustment). |
Co-authored-by: alextrical <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: alextrical <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: alextrical <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Description
Add support for making X optional also (so having only an Extruder is a possibility.)
Benefits
More modularity, smaller code for extruder-only projects.