Fix M503C #25687
Fix M503C #25687
Conversation
|
Doesn't work on AVR.. file is created of correct length but does not contain correct data. (on a atmega2560) |
that's weird. With my board and yours fix suggestions I had a 0 file size + board reboot Edit: My board is stm32 |
thisiskeithb
added
Needs: Work
|
basically my solution is not correct/complete and this pr based on it is premature. Which is why it was sitting there... |
|
@ellensp as per your wish, but this solve the problem on stm32 and it also should on avr |
|
I just retested this on ramps and it worked fine!!!!!!! I have no idea why it didn't work for me when it was testing it months ago... Please reinstate, my bad. |
|
@ellensp not sure you did what I did but I suspect that using MediaFile call you pass the pointer as a standard ram pointer. That's because you got a correct size but wrong contents. Not sure why on stm32 it reboot the board since AFAIK stm32 doesn't have the same flash memory access method used by avr. But as I stated before maybe there is a better way to achieve what I did, it comes in mind to create a new method in MediaFile class that accepts P_STR pointers |
Are you asking me to reopen PR (Not sure translator did correct job)? Isn't possible to reopen it from github? Edit: I tryed a new translation and now I get a more "sensed" translation |
This exhume MarlinFirmware#25687 closed because of a misunderstaning
This fixes #25501
I've replicated @ellensp fix suggestion but I had a board reboot due to PROGMEM data source.
Not sure this is the best solution but it works