fix reading rle bmp data from pgm on avr #26827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
COMPACT_CUSTOM_BOOTSCREEN does not work on 8 bit AVR machines
The data custom_start_bmp_rle is stored in PROGMEM, but it was being read out of standard memory,
Updated to use pgm_read_byte so it is read out of PROGMEM on AVR's
Requirements
SHOW_CUSTOM_BOOTSCREEN with COMPACT_CUSTOM_BOOTSCREEN on a AVR controller
With a appropriately created _Bootscreen.h with custom_start_bmp_rle data.
Benefits
Works as expected
Related Issues
https://discord.com/channels/461605380783472640/491165528295997450/1212235657930350622